Re: [PATCH kcsan 3/3] kcsan: Fix encoding masks and regain address bit

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 11:19, Boqun Feng wrote: > > send a v2 for this one. > > Let me add an ack for that one, thanks! Thank you! -- Marco

Re: [PATCH kcsan 3/3] kcsan: Fix encoding masks and regain address bit

2020-11-06 Thread Boqun Feng
On Fri, Nov 06, 2020 at 10:03:21AM +0100, Marco Elver wrote: > On Fri, 6 Nov 2020 at 02:23, Boqun Feng wrote: > > Hi Marco, > > > > On Thu, Nov 05, 2020 at 02:03:24PM -0800, paul...@kernel.org wrote: > > > From: Marco Elver > > > > > > The watchpoint encoding masks for size and address were

Re: [PATCH kcsan 3/3] kcsan: Fix encoding masks and regain address bit

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 02:23, Boqun Feng wrote: > Hi Marco, > > On Thu, Nov 05, 2020 at 02:03:24PM -0800, paul...@kernel.org wrote: > > From: Marco Elver > > > > The watchpoint encoding masks for size and address were off-by-one bit > > each, with the size mask using 1 unnecessary bit and the

Re: [PATCH kcsan 3/3] kcsan: Fix encoding masks and regain address bit

2020-11-05 Thread Boqun Feng
Hi Marco, On Thu, Nov 05, 2020 at 02:03:24PM -0800, paul...@kernel.org wrote: > From: Marco Elver > > The watchpoint encoding masks for size and address were off-by-one bit > each, with the size mask using 1 unnecessary bit and the address mask > missing 1 bit. However, due to the way the size

[PATCH kcsan 3/3] kcsan: Fix encoding masks and regain address bit

2020-11-05 Thread paulmck
From: Marco Elver The watchpoint encoding masks for size and address were off-by-one bit each, with the size mask using 1 unnecessary bit and the address mask missing 1 bit. However, due to the way the size is shifted into the encoded watchpoint, we were effectively wasting and never using the