Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-21 Thread Marek Behun
On Mon, 21 Sep 2020 16:03:22 +0200 Simon Guinot wrote: > On Mon, Sep 21, 2020 at 03:02:08PM +0200, Marek Behun wrote: > > On Mon, 21 Sep 2020 14:53:43 +0200 > > Simon Guinot wrote: > > > > > On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote: > > > > On Fri, 18 Sep 2020 15:02:06

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-21 Thread Simon Guinot
On Mon, Sep 21, 2020 at 03:02:08PM +0200, Marek Behun wrote: > On Mon, 21 Sep 2020 14:53:43 +0200 > Simon Guinot wrote: > > > On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote: > > > On Fri, 18 Sep 2020 15:02:06 +0200 > > > Simon Guinot wrote: > > > > > > > On Thu, Sep 17, 2020 at

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-21 Thread Marek Behun
On Mon, 21 Sep 2020 14:53:43 +0200 Simon Guinot wrote: > On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote: > > On Fri, 18 Sep 2020 15:02:06 +0200 > > Simon Guinot wrote: > > > > > On Thu, Sep 17, 2020 at 01:16:50AM +0200, Marek Behún wrote: > > > > > > Hi Marek, > > > > > > >

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-21 Thread Simon Guinot
On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote: > On Fri, 18 Sep 2020 15:02:06 +0200 > Simon Guinot wrote: > > > On Thu, Sep 17, 2020 at 01:16:50AM +0200, Marek Behún wrote: > > > > Hi Marek, > > > > > By using struct led_init_data when registering we do not need to parse > > >

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-18 Thread Marek Behun
On Fri, 18 Sep 2020 15:02:06 +0200 Simon Guinot wrote: > On Thu, Sep 17, 2020 at 01:16:50AM +0200, Marek Behún wrote: > > Hi Marek, > > > By using struct led_init_data when registering we do not need to parse > > `label` DT property nor `linux,default-trigger` property. > > > > Also, move

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-18 Thread Simon Guinot
On Thu, Sep 17, 2020 at 01:16:50AM +0200, Marek Behún wrote: Hi Marek, > By using struct led_init_data when registering we do not need to parse > `label` DT property nor `linux,default-trigger` property. > > Also, move forward from platform data to device tree only: > since commit c7896490dd1a

[PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-16 Thread Marek Behún
By using struct led_init_data when registering we do not need to parse `label` DT property nor `linux,default-trigger` property. Also, move forward from platform data to device tree only: since commit c7896490dd1a ("leds: ns2: Absorb platform data") the platform data structure is absorbed into