Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 09:59:32 PM, Andrew Morton wrote: > On Tue, 23 Sep 2014 21:51:09 -0700 ashutosh dixit > wrote: > >> On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley wrote: >> > On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton >> > wrote: >> >> Can't we just fix the Makefiles? Cook up a

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Andrew Morton
On Tue, 23 Sep 2014 21:51:09 -0700 ashutosh dixit wrote: > On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley wrote: > > On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton > > wrote: > >> Can't we just fix the Makefiles? Cook up a rule which makes > >> headers_install (if needed) before building

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley wrote: > On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton > wrote: >> Can't we just fix the Makefiles? Cook up a rule which makes >> headers_install (if needed) before building Documentation/? > > Currently, the ordering is enforced by >

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton wrote: > Can't we just fix the Makefiles? Cook up a rule which makes > headers_install (if needed) before building Documentation/? Currently, the ordering is enforced by

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Andrew Morton
On Tue, 23 Sep 2014 19:47:11 -0400 Peter Foley wrote: > On Tue, Sep 23, 2014 at 7:38 PM, Andrew Morton > wrote: > > This build error is caused by compiling mpssd prior to `make > > headers_install'. > > > > There's really no reason to check the kernel version. If someone > > transplants mpssd

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 7:38 PM, Andrew Morton wrote: > This build error is caused by compiling mpssd prior to `make > headers_install'. > > There's really no reason to check the kernel version. If someone > transplants mpssd out of its distributed kernel and into some older > kernel then a

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Andrew Morton
On Tue, 23 Sep 2014 19:23:39 -0400 Peter Foley wrote: > On Tue, Sep 23, 2014 at 6:59 PM, ashutosh dixit > wrote: > > Correct, if things in Documentation will be compiled against the headers > > in the kernel source tree then this patch is not required. However, > > Andrew had reported the

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 6:59 PM, ashutosh dixit wrote: > Correct, if things in Documentation will be compiled against the headers > in the kernel source tree then this patch is not required. However, > Andrew had reported the following compile error: > >> In file included from

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 02:46:10 PM, Randy Dunlap wrote: > On 09/23/14 14:55, Ashutosh Dixit wrote: >> mpssd depends on headers available in kernels >= 3.13. Therefore >> disable the build for kernels < 3.13. For kernels < 3.13, to avoid the >> appearance of a build break simply print an error

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 5:55 PM, Ashutosh Dixit wrote: > mpssd depends on headers available in kernels >= 3.13. Therefore > disable the build for kernels < 3.13. For kernels < 3.13, to avoid the > appearance of a build break simply print an error message and exit. > Everything in Documentation

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Randy Dunlap
On 09/23/14 14:55, Ashutosh Dixit wrote: > mpssd depends on headers available in kernels >= 3.13. Therefore > disable the build for kernels < 3.13. For kernels < 3.13, to avoid the > appearance of a build break simply print an error message and exit. Why is this needed? This file won't be built

[PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Ashutosh Dixit
mpssd depends on headers available in kernels >= 3.13. Therefore disable the build for kernels < 3.13. For kernels < 3.13, to avoid the appearance of a build break simply print an error message and exit. Reported-by: Andrew Morton Cc: Randy Dunlap Cc: Greg Kroah-Hartman Cc: Peter Foley

[PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Ashutosh Dixit
mpssd depends on headers available in kernels = 3.13. Therefore disable the build for kernels 3.13. For kernels 3.13, to avoid the appearance of a build break simply print an error message and exit. Reported-by: Andrew Morton a...@linux-foundation.org Cc: Randy Dunlap rdun...@infradead.org Cc:

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Randy Dunlap
On 09/23/14 14:55, Ashutosh Dixit wrote: mpssd depends on headers available in kernels = 3.13. Therefore disable the build for kernels 3.13. For kernels 3.13, to avoid the appearance of a build break simply print an error message and exit. Why is this needed? This file won't be built in any

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 5:55 PM, Ashutosh Dixit ashutosh.di...@intel.com wrote: mpssd depends on headers available in kernels = 3.13. Therefore disable the build for kernels 3.13. For kernels 3.13, to avoid the appearance of a build break simply print an error message and exit. Everything in

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 02:46:10 PM, Randy Dunlap rdun...@infradead.org wrote: On 09/23/14 14:55, Ashutosh Dixit wrote: mpssd depends on headers available in kernels = 3.13. Therefore disable the build for kernels 3.13. For kernels 3.13, to avoid the appearance of a build break simply print

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 6:59 PM, ashutosh dixit ashutosh.di...@intel.com wrote: Correct, if things in Documentation will be compiled against the headers in the kernel source tree then this patch is not required. However, Andrew had reported the following compile error: In file included from

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Andrew Morton
On Tue, 23 Sep 2014 19:23:39 -0400 Peter Foley pefol...@pefoley.com wrote: On Tue, Sep 23, 2014 at 6:59 PM, ashutosh dixit ashutosh.di...@intel.com wrote: Correct, if things in Documentation will be compiled against the headers in the kernel source tree then this patch is not required.

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 7:38 PM, Andrew Morton a...@linux-foundation.org wrote: This build error is caused by compiling mpssd prior to `make headers_install'. There's really no reason to check the kernel version. If someone transplants mpssd out of its distributed kernel and into some older

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Andrew Morton
On Tue, 23 Sep 2014 19:47:11 -0400 Peter Foley pefol...@pefoley.com wrote: On Tue, Sep 23, 2014 at 7:38 PM, Andrew Morton a...@linux-foundation.org wrote: This build error is caused by compiling mpssd prior to `make headers_install'. There's really no reason to check the kernel version.

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Peter Foley
On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton a...@linux-foundation.org wrote: Can't we just fix the Makefiles? Cook up a rule which makes headers_install (if needed) before building Documentation/? Currently, the ordering is enforced by

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley pefol...@pefoley.com wrote: On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton a...@linux-foundation.org wrote: Can't we just fix the Makefiles? Cook up a rule which makes headers_install (if needed) before building Documentation/? Currently, the

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread Andrew Morton
On Tue, 23 Sep 2014 21:51:09 -0700 ashutosh dixit ashutosh.di...@intel.com wrote: On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley pefol...@pefoley.com wrote: On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton a...@linux-foundation.org wrote: Can't we just fix the Makefiles? Cook up a rule

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 09:59:32 PM, Andrew Morton a...@linux-foundation.org wrote: On Tue, 23 Sep 2014 21:51:09 -0700 ashutosh dixit ashutosh.di...@intel.com wrote: On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley pefol...@pefoley.com wrote: On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton