Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-23 Thread Jon Maxwell
> I have no more comments except for style problems (bracket position, > indentation, type mismatch). > thank you for rewriting :) np, yes this is a draft but I will make sure complies with checkpatch.pl before submitting it. Regards Jon > > Thanks, > Toshiaki Makita > > > > > $ diff -Naur

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-23 Thread Toshiaki Makita
(2014/05/23 13:59), Jon Maxwell wrote: ... > Makita-san, > > I recoded this using your idea and ran it through a reproducer. > It work fine. After some more consideration I agree that > setting fdb->dst = source is only required when source != fdb->dst. > > Thanks for your suggestions. This is t

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-22 Thread Jon Maxwell
er.kernel.org, jpi...@redhat.com, jmaxw...@redhat.com > > Sent: Wednesday, May 14, 2014 10:34:38 AM > > Subject: Re: [PATCH net] bridge: notify user space of fdb port change > > > > (2014/05/13 16:55), Jon Maxwell wrote: > > > From: Jon Maxwell > >

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
edhat.com > Sent: Friday, May 16, 2014 6:12:51 PM > Subject: Re: [PATCH net] bridge: notify user space of fdb port change > > Please use this patch. My bad, the previous one > incorrectly did the notify before fdb->added_by_user = 1. > I just realized I did the port compar

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
..@redhat.com, > bri...@lists.linux-foundation.org, net...@vger.kernel.org, > linux-kernel@vger.kernel.org, jpi...@redhat.com, > jmaxw...@redhat.com, "Jon Maxwell" > Sent: Friday, May 16, 2014 6:08:39 PM > Subject: [PATCH net] bridge: notify user space of fdb port change > >

[PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
From: Jon Maxwell There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network. However some NICs have an inbuilt

[PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
From: Jon Maxwell There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network. However some NICs have an inbuilt

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-14 Thread Jon Maxwell
hat.com, jmaxw...@redhat.com > Sent: Wednesday, May 14, 2014 10:34:38 AM > Subject: Re: [PATCH net] bridge: notify user space of fdb port change > > (2014/05/13 16:55), Jon Maxwell wrote: > > From: Jon Maxwell > > > > There has been a number incidents recently where c

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-13 Thread Toshiaki Makita
(2014/05/13 16:55), Jon Maxwell wrote: > From: Jon Maxwell > > There has been a number incidents recently where customers running KVM have > reported that VM hosts on different Hypervisors are unreachable. Based on > pcap traces we found that the bridge was broadcasting the ARP request out > o

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-13 Thread Stephen Hemminger
On Tue, 13 May 2014 17:16:11 +0200 Jiri Pirko wrote: > Tue, May 13, 2014 at 09:55:08AM CEST, jmaxwel...@gmail.com wrote: > >From: Jon Maxwell > > > >There has been a number incidents recently where customers running KVM have > >reported that VM hosts on different Hypervisors are unreachable. Ba

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-13 Thread Jiri Pirko
Tue, May 13, 2014 at 09:55:08AM CEST, jmaxwel...@gmail.com wrote: >From: Jon Maxwell > >There has been a number incidents recently where customers running KVM have >reported that VM hosts on different Hypervisors are unreachable. Based on >pcap traces we found that the bridge was broadcasting th

[PATCH net] bridge: notify user space of fdb port change

2014-05-13 Thread Jon Maxwell
From: Jon Maxwell There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network. However some NICs have an inbuilt