Re: [PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING flag after calling ether_setup

2020-10-21 Thread Xie He
On Wed, Oct 21, 2020 at 6:02 PM Jakub Kicinski wrote: > > Applied, thank you. > > In the future please try to provide a Fixes: tag. OK. Thanks! I'll remember this in the future!

Re: [PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING flag after calling ether_setup

2020-10-21 Thread Jakub Kicinski
On Mon, 19 Oct 2020 23:34:20 -0700 Xie He wrote: > This driver calls ether_setup to set up the network device. > The ether_setup function would add the IFF_TX_SKB_SHARING flag to the > device. This flag indicates that it is safe to transmit shared skbs to > the device. > > However, this is not

[PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING flag after calling ether_setup

2020-10-20 Thread Xie He
This driver calls ether_setup to set up the network device. The ether_setup function would add the IFF_TX_SKB_SHARING flag to the device. This flag indicates that it is safe to transmit shared skbs to the device. However, this is not true. This driver may pad the frame (in eth_tx) before