Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-06-03 Thread Russell King - ARM Linux admin
On Wed, Jun 03, 2020 at 03:21:47PM +0200, Andrew Lunn wrote: > On Tue, Jun 02, 2020 at 11:50:17PM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, May 29, 2020 at 06:33:40PM +0200, Andrew Lunn wrote: > > > Given the current code, you cannot. Now we understand the > > > requirements, we

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-06-03 Thread Andrew Lunn
On Tue, Jun 02, 2020 at 11:50:17PM +0100, Russell King - ARM Linux admin wrote: > On Fri, May 29, 2020 at 06:33:40PM +0200, Andrew Lunn wrote: > > Given the current code, you cannot. Now we understand the > > requirements, we can come up with some ideas how to do this properly. > > Okay, I've

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-06-03 Thread Russell King - ARM Linux admin
On Tue, Jun 02, 2020 at 11:50:16PM +0100, Russell King - ARM Linux admin wrote: > On Fri, May 29, 2020 at 06:33:40PM +0200, Andrew Lunn wrote: > > Given the current code, you cannot. Now we understand the > > requirements, we can come up with some ideas how to do this properly. > > Okay, I've

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-06-02 Thread Russell King - ARM Linux admin
On Fri, May 29, 2020 at 06:33:40PM +0200, Andrew Lunn wrote: > Given the current code, you cannot. Now we understand the > requirements, we can come up with some ideas how to do this properly. Okay, I've been a little quiet because of sorting out the ARM tree for merging with Linus (now done) and

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-06-02 Thread Thomas Bogendoerfer
On Fri, 29 May 2020 18:33:40 +0200 Andrew Lunn wrote: > > > By propagated, you mean if the external link is down, the link between > > > the switch and node 1 will also be forced down, at the SERDES level? > > > > yes > > > > > And if external ports are down, the nodes cannot talk to each

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-29 Thread Russell King - ARM Linux admin
On Fri, May 29, 2020 at 06:25:04PM +0200, Andrew Lunn wrote: > > I wonder how much risk there is to changing that, so we force the link > > down if phylink says the link should be down, otherwise we force the > > speed/duplex, disable AN, and allow the link to come up depending on > > the serdes

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-29 Thread Andrew Lunn
> > By propagated, you mean if the external link is down, the link between > > the switch and node 1 will also be forced down, at the SERDES level? > > yes > > > And if external ports are down, the nodes cannot talk to each other? > > correct > > > External link down causes the whole in box

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-29 Thread Andrew Lunn
> I wonder how much risk there is to changing that, so we force the link > down if phylink says the link should be down, otherwise we force the > speed/duplex, disable AN, and allow the link to come up depending on > the serdes status. It /sounds/ like something sane to do. Hi Russell I

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-29 Thread Thomas Bogendoerfer
On Fri, 29 May 2020 16:59:28 +0200 Andrew Lunn wrote: > On Fri, May 29, 2020 at 01:05:39PM +0200, Thomas Bogendoerfer wrote: > > On Thu, 28 May 2020 23:04:20 +0100 > > Russell King - ARM Linux admin wrote: > > > > > Can you explain this please? Just as we think we understand what's > > >

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-29 Thread Russell King - ARM Linux admin
On Fri, May 29, 2020 at 04:59:28PM +0200, Andrew Lunn wrote: > On Fri, May 29, 2020 at 01:05:39PM +0200, Thomas Bogendoerfer wrote: > > On Thu, 28 May 2020 23:04:20 +0100 > > Russell King - ARM Linux admin wrote: > > > > > Can you explain this please? Just as we think we understand what's > > >

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-29 Thread Andrew Lunn
On Fri, May 29, 2020 at 01:05:39PM +0200, Thomas Bogendoerfer wrote: > On Thu, 28 May 2020 23:04:20 +0100 > Russell King - ARM Linux admin wrote: > > > Can you explain this please? Just as we think we understand what's > > going on here, you throw in a new comment that makes us confused. > >

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-29 Thread Thomas Bogendoerfer
On Thu, 28 May 2020 23:04:20 +0100 Russell King - ARM Linux admin wrote: > Can you explain this please? Just as we think we understand what's > going on here, you throw in a new comment that makes us confused. sorry about that. > You said previously that the mvpp2 was connected to a switch,

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Russell King - ARM Linux admin
On Thu, May 28, 2020 at 08:43:12PM +0200, Thomas Bogendoerfer wrote: > On Thu, 28 May 2020 15:48:05 +0100 > Russell King - ARM Linux admin wrote: > > > On Thu, May 28, 2020 at 04:33:35PM +0200, Thomas Bogendoerfer wrote: > > > below is the dts part for the two network interfaces. The switch to >

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Andrew Lunn
On Thu, May 28, 2020 at 08:43:12PM +0200, Thomas Bogendoerfer wrote: > On Thu, 28 May 2020 15:48:05 +0100 > Russell King - ARM Linux admin wrote: > > > On Thu, May 28, 2020 at 04:33:35PM +0200, Thomas Bogendoerfer wrote: > > > below is the dts part for the two network interfaces. The switch to >

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Thomas Bogendoerfer
On Thu, 28 May 2020 18:33:27 +0200 Andrew Lunn wrote: > On Thu, May 28, 2020 at 04:33:35PM +0200, Thomas Bogendoerfer wrote: > > below is the dts part for the two network interfaces. The switch to > > the outside has two ports, which correlate to the two internal ports. > > And the switch

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Thomas Bogendoerfer
On Thu, 28 May 2020 15:48:05 +0100 Russell King - ARM Linux admin wrote: > On Thu, May 28, 2020 at 04:33:35PM +0200, Thomas Bogendoerfer wrote: > > below is the dts part for the two network interfaces. The switch to > > the outside has two ports, which correlate to the two internal ports. > >

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Andrew Lunn
On Thu, May 28, 2020 at 04:33:35PM +0200, Thomas Bogendoerfer wrote: > below is the dts part for the two network interfaces. The switch to > the outside has two ports, which correlate to the two internal ports. > And the switch propagates the link state of the external ports to > the internal

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Russell King - ARM Linux admin
On Thu, May 28, 2020 at 04:33:35PM +0200, Thomas Bogendoerfer wrote: > below is the dts part for the two network interfaces. The switch to > the outside has two ports, which correlate to the two internal ports. > And the switch propagates the link state of the external ports to > the internal

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Thomas Bogendoerfer
On Thu, 28 May 2020 14:56:08 +0100 Russell King - ARM Linux admin wrote: > On Thu, May 28, 2020 at 03:17:33PM +0200, Thomas Bogendoerfer wrote: > > On Thu, 28 May 2020 14:07:38 +0100 > > Russell King - ARM Linux admin wrote: > > > > > On Thu, May 28, 2020 at 02:11:21PM +0200, Thomas

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Russell King - ARM Linux admin
On Thu, May 28, 2020 at 03:17:33PM +0200, Thomas Bogendoerfer wrote: > On Thu, 28 May 2020 14:07:38 +0100 > Russell King - ARM Linux admin wrote: > > > On Thu, May 28, 2020 at 02:11:21PM +0200, Thomas Bogendoerfer wrote: > > > Commit d14e078f23cc ("net: marvell: mvpp2: only reprogram what is >

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Thomas Bogendoerfer
On Thu, 28 May 2020 14:07:38 +0100 Russell King - ARM Linux admin wrote: > On Thu, May 28, 2020 at 02:11:21PM +0200, Thomas Bogendoerfer wrote: > > Commit d14e078f23cc ("net: marvell: mvpp2: only reprogram what is necessary > > on mac_config") disabled auto negotiation bypass completely, which

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Russell King - ARM Linux admin
On Thu, May 28, 2020 at 02:11:21PM +0200, Thomas Bogendoerfer wrote: > Commit d14e078f23cc ("net: marvell: mvpp2: only reprogram what is necessary > on mac_config") disabled auto negotiation bypass completely, which breaks > platforms enabling bypass via firmware (not the best option, but it

[PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-05-28 Thread Thomas Bogendoerfer
Commit d14e078f23cc ("net: marvell: mvpp2: only reprogram what is necessary on mac_config") disabled auto negotiation bypass completely, which breaks platforms enabling bypass via firmware (not the best option, but it worked). Since 1000BaseX/2500BaseX ports neither negotiate speed nor duplex