Re: [PATCH net] net: sonic: remove dev_kfree_skb before return NETDEV_TX_BUSY

2019-09-04 Thread maowenan
On 2019/9/4 18:19, Eric Dumazet wrote: > > > On 9/4/19 11:42 AM, Mao Wenan wrote: >> When dma_map_single is failed to map buffer, skb can't be freed >> before sonic driver return to stack with NETDEV_TX_BUSY, because >> this skb may be requeued to qdisc, it might trigger use-after-free. >> >>

Re: [PATCH net] net: sonic: remove dev_kfree_skb before return NETDEV_TX_BUSY

2019-09-04 Thread Eric Dumazet
On 9/4/19 11:42 AM, Mao Wenan wrote: > When dma_map_single is failed to map buffer, skb can't be freed > before sonic driver return to stack with NETDEV_TX_BUSY, because > this skb may be requeued to qdisc, it might trigger use-after-free. > > Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move

Re: [PATCH net] net: sonic: remove dev_kfree_skb before return NETDEV_TX_BUSY

2019-09-04 Thread Thomas Bogendoerfer
On Wed, Sep 04, 2019 at 05:42:11PM +0800, Mao Wenan wrote: > When dma_map_single is failed to map buffer, skb can't be freed > before sonic driver return to stack with NETDEV_TX_BUSY, because > this skb may be requeued to qdisc, it might trigger use-after-free. > > Fixes: d9fb9f384292

[PATCH net] net: sonic: remove dev_kfree_skb before return NETDEV_TX_BUSY

2019-09-04 Thread Mao Wenan
When dma_map_single is failed to map buffer, skb can't be freed before sonic driver return to stack with NETDEV_TX_BUSY, because this skb may be requeued to qdisc, it might trigger use-after-free. Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers")