Re: [PATCH net] vhost: correctly remove wait queue during poll failure

2018-03-27 Thread Michael S. Tsirkin
On Tue, Mar 27, 2018 at 05:43:14PM +0800, Jason Wang wrote: > > > On 2018年03月27日 17:28, Darren Kenny wrote: > > Hi Jason, > > > > On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote: > > > We tried to remove vq poll from wait queue, but do not check whether > > > or not it was in a list b

Re: [PATCH net] vhost: correctly remove wait queue during poll failure

2018-03-27 Thread Jason Wang
On 2018年03月27日 17:28, Darren Kenny wrote: Hi Jason, On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it wa

Re: [PATCH net] vhost: correctly remove wait queue during poll failure

2018-03-27 Thread Darren Kenny
Hi Jason, On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it was in a list. This text seems at odds with t

[PATCH net] vhost: correctly remove wait queue during poll failure

2018-03-26 Thread Jason Wang
We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it was in a list. Reported-by: syzbot+c0272972b01b872e6...@syzkaller.appspotmail.com Fixes: 2b8b328b61c79 ("vhost_net: han