Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-30 Thread Jason Wang
On 08/28/2015 08:25 PM, Vlad Yasevich wrote: > On 08/27/2015 10:42 PM, Jason Wang wrote: >> > >> > >> > On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: >>> >> On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: >>> >>> On 08/26/2015 12:32 AM, Vlad Yasevich wrote: >

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-30 Thread Jason Wang
On 08/28/2015 08:25 PM, Vlad Yasevich wrote: On 08/27/2015 10:42 PM, Jason Wang wrote: On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: On 08/26/2015 12:32 AM, Vlad Yasevich wrote: On 08/25/2015 07:30 AM, Jason Wang

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-28 Thread Vlad Yasevich
On 08/27/2015 10:42 PM, Jason Wang wrote: > > > On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: >> On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: >>> >>> On 08/26/2015 12:32 AM, Vlad Yasevich wrote: On 08/25/2015 07:30 AM, Jason Wang wrote: > On 08/25/2015 06:17 PM,

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-28 Thread Vlad Yasevich
On 08/27/2015 10:42 PM, Jason Wang wrote: On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: On 08/26/2015 12:32 AM, Vlad Yasevich wrote: On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote:

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-27 Thread Jason Wang
On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: > On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: >> >> On 08/26/2015 12:32 AM, Vlad Yasevich wrote: >>> On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: > On Mon, Aug 24, 2015 at

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-27 Thread Michael S. Tsirkin
On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: > > > On 08/26/2015 12:32 AM, Vlad Yasevich wrote: > > On 08/25/2015 07:30 AM, Jason Wang wrote: > >> > >> On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: > >>> On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: > > For

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-27 Thread Jason Wang
On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: On 08/26/2015 12:32 AM, Vlad Yasevich wrote: On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: On Mon, Aug 24, 2015 at 04:33:12PM +0800,

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-27 Thread Michael S. Tsirkin
On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: On 08/26/2015 12:32 AM, Vlad Yasevich wrote: On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Jason Wang
On 08/26/2015 12:32 AM, Vlad Yasevich wrote: > On 08/25/2015 07:30 AM, Jason Wang wrote: >> >> On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: >>> On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: > For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. > >

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Vlad Yasevich
On 08/25/2015 07:30 AM, Jason Wang wrote: > > > On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: >> On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Jason Wang
On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: > On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: >> > For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. >> > >> > For macvtap, after commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 >> > ("macvtap: Add support of

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Michael S. Tsirkin
On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: > For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. > > For macvtap, after commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 > ("macvtap: Add support of packet capture on macvtap > device."). Multiqueue macvtap suffers

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Vlad Yasevich
On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Jason Wang
On 08/26/2015 12:32 AM, Vlad Yasevich wrote: On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Michael S. Tsirkin
On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 (macvtap: Add support of packet capture on macvtap device.). Multiqueue macvtap suffers from

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Jason Wang
On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 (macvtap: Add support of packet capture

[PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-24 Thread Jason Wang
For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 ("macvtap: Add support of packet capture on macvtap device."). Multiqueue macvtap suffers from single qdisc lock contention. This is because macvtap claims a non

[PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-24 Thread Jason Wang
For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 (macvtap: Add support of packet capture on macvtap device.). Multiqueue macvtap suffers from single qdisc lock contention. This is because macvtap claims a non