Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
On 8/13/19 1:54 PM, Terry Duncan wrote: On 8/13/19 11:28 AM, Tao Ren wrote: On 8/13/19 9:31 AM, Terry Duncan wrote: Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
On 8/13/19 12:52 PM, Ben Wei wrote: On 8/13/19 9:31 AM, Terry Duncan wrote: Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system address without it affecting the BMC

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
On 8/13/19 11:28 AM, Tao Ren wrote: On 8/13/19 9:31 AM, Terry Duncan wrote: Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system address without it affecting the BMC

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system address without it affecting the BMC address. I was about to send patches to add support for the Intel adapters when

Re: [Potential Spoof] Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-09 Thread Vijay Khemka
On 8/8/19, 3:27 PM, "openbmc on behalf of Tao Ren" wrote: On 8/8/19 2:16 PM, Andrew Lunn wrote: > On Thu, Aug 08, 2019 at 07:02:54PM +, Tao Ren wrote: >> Hi Andrew, >> >> On 8/8/19 6:32 AM, Andrew Lunn wrote: Let me prepare patch v2 using device tree. I'm not

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-08 Thread Tao Ren
On 8/8/19 4:03 PM, Andrew Lunn wrote: >> After giving it more thought, I'm thinking about adding ncsi dt node >> with following structure (mac/ncsi similar to mac/mdio/phy): >> >> { >> /* MAC properties... */ >> >> use-ncsi; > > This property seems to be specific to Faraday FTGMAC100.

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-08 Thread Andrew Lunn
> After giving it more thought, I'm thinking about adding ncsi dt node > with following structure (mac/ncsi similar to mac/mdio/phy): > > { > /* MAC properties... */ > > use-ncsi; This property seems to be specific to Faraday FTGMAC100. Are you going to make it more generic? >

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-08 Thread Tao Ren
On 8/8/19 2:16 PM, Andrew Lunn wrote: > On Thu, Aug 08, 2019 at 07:02:54PM +, Tao Ren wrote: >> Hi Andrew, >> >> On 8/8/19 6:32 AM, Andrew Lunn wrote: Let me prepare patch v2 using device tree. I'm not sure if standard "mac-address" fits this situation because all we need is an

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-08 Thread Andrew Lunn
On Thu, Aug 08, 2019 at 07:02:54PM +, Tao Ren wrote: > Hi Andrew, > > On 8/8/19 6:32 AM, Andrew Lunn wrote: > >> Let me prepare patch v2 using device tree. I'm not sure if standard > >> "mac-address" fits this situation because all we need is an offset > >> (integer) and BMC MAC is calculated

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-08 Thread Tao Ren
Hi Andrew, On 8/8/19 6:32 AM, Andrew Lunn wrote: >> Let me prepare patch v2 using device tree. I'm not sure if standard >> "mac-address" fits this situation because all we need is an offset >> (integer) and BMC MAC is calculated by adding the offset to NIC's >> MAC address. Anyways, let me work

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-08 Thread Andrew Lunn
> Let me prepare patch v2 using device tree. I'm not sure if standard > "mac-address" fits this situation because all we need is an offset > (integer) and BMC MAC is calculated by adding the offset to NIC's > MAC address. Anyways, let me work out v2 patch we can discuss more > then. Hi Tao I

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Tao Ren
On 8/7/19 10:36 AM, Vijay Khemka wrote: > Lgtm except one small comment below. > > On 8/6/19, 5:22 PM, "openbmc on behalf of Tao Ren" > tao...@fb.com> wrote: > > Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base > MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Tao Ren
On 8/7/19 11:41 AM, Andrew Lunn wrote: > On Wed, Aug 07, 2019 at 11:25:18AM -0700, Jakub Kicinski wrote: >> On Tue, 6 Aug 2019 17:21:18 -0700, Tao Ren wrote: >>> Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base >>> MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Andrew Lunn
On Wed, Aug 07, 2019 at 11:25:18AM -0700, Jakub Kicinski wrote: > On Tue, 6 Aug 2019 17:21:18 -0700, Tao Ren wrote: > > Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base > > MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabled. The logic > > doesn't work for

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Jakub Kicinski
On Tue, 6 Aug 2019 17:21:18 -0700, Tao Ren wrote: > Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base > MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabled. The logic > doesn't work for platforms with different BMC MAC offset: for example, > Facebook Yamp BMC's

Re:[PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Vijay Khemka
Lgtm except one small comment below. On 8/6/19, 5:22 PM, "openbmc on behalf of Tao Ren" wrote: Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabled. The logic doesn't work for platforms with

[PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-06 Thread Tao Ren
Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabled. The logic doesn't work for platforms with different BMC MAC offset: for example, Facebook Yamp BMC's MAC address is calculated by adding 2 to NIC's base MAC