Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-13 Thread Dan Carpenter
On Mon, Aug 12, 2019 at 10:19:27AM -0700, Kees Cook wrote: > On Wed, Aug 07, 2019 at 01:50:42PM +0300, Dan Carpenter wrote: > > On Tue, Aug 06, 2019 at 06:41:44PM +0200, Oliver Hartkopp wrote: > > > I compiled the code (the original version), but I do not get that "Should > > > it > > > be

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-12 Thread Kees Cook
On Wed, Aug 07, 2019 at 01:50:42PM +0300, Dan Carpenter wrote: > On Tue, Aug 06, 2019 at 06:41:44PM +0200, Oliver Hartkopp wrote: > > I compiled the code (the original version), but I do not get that "Should it > > be static?" warning: > > > > user@box:~/net-next$ make C=1 > > CALL

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-12 Thread Oliver Hartkopp
On 12/08/2019 07.48, maowenan wrote: On 2019/8/7 0:41, Oliver Hartkopp wrote: I compiled the code (the original version), but I do not get that "Should it be static?" warning: here are my steps for net/can/bcm.c, make allmodconfig ARCH=mips CROSS_COMPILE=mips-linux-gnu- make C=2

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-11 Thread maowenan
On 2019/8/7 0:41, Oliver Hartkopp wrote: > Hello Dan, > > On 06/08/2019 15.52, Dan Carpenter wrote: >> On Fri, Aug 02, 2019 at 10:10:20AM +0200, Oliver Hartkopp wrote: > >>> Btw. what kind of compiler/make switches are you using so that I can see >>> these warnings myself the next time? >> >>

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-07 Thread Dan Carpenter
On Tue, Aug 06, 2019 at 06:41:44PM +0200, Oliver Hartkopp wrote: > I compiled the code (the original version), but I do not get that "Should it > be static?" warning: > > user@box:~/net-next$ make C=1 > CALLscripts/checksyscalls.sh > CALLscripts/atomic/check-atomics.sh > DESCEND

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-06 Thread Oliver Hartkopp
Hello Dan, On 06/08/2019 15.52, Dan Carpenter wrote: On Fri, Aug 02, 2019 at 10:10:20AM +0200, Oliver Hartkopp wrote: Btw. what kind of compiler/make switches are you using so that I can see these warnings myself the next time? These are Sparse warnings, not from GCC. I compiled the code

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-06 Thread Dan Carpenter
On Fri, Aug 02, 2019 at 10:10:20AM +0200, Oliver Hartkopp wrote: > On 02/08/2019 05.36, Mao Wenan wrote: > > There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd > > and raw_sock_no_ioctlcmd as static. > > > > net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-04 Thread maowenan
please drop this mail. On 2019/8/5 9:22, Mao Wenan wrote: > There are two warnings in net/can, fix them by setting bcm_sock_no_ioctlcmd > and raw_sock_no_ioctlcmd as static. > > net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not > declared. Should it be static? >

[PATCH net-next] net: can: Fix compiling warning

2019-08-04 Thread Mao Wenan
There are two warnings in net/can, fix them by setting bcm_sock_no_ioctlcmd and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static? net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared.

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-04 Thread maowenan
On 2019/8/2 16:59, Sergei Shtylyov wrote: > Hello! > > On 02.08.2019 6:36, Mao Wenan wrote: > >> There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd > >Warnings. :-) Thanks, I will send v2. > >> and raw_sock_no_ioctlcmd as static. >> >> net/can/bcm.c:1683:5:

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-02 Thread Sergei Shtylyov
Hello! On 02.08.2019 6:36, Mao Wenan wrote: There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd Warnings. :-) and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static?

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-02 Thread maowenan
On 2019/8/2 16:10, Oliver Hartkopp wrote: > On 02/08/2019 05.36, Mao Wenan wrote: >> There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd >> and raw_sock_no_ioctlcmd as static. >> >> net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not >> declared. Should

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-02 Thread Oliver Hartkopp
On 02/08/2019 05.36, Mao Wenan wrote: There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static? net/can/raw.c:840:5: warning: symbol

[PATCH net-next] net: can: Fix compiling warning

2019-08-01 Thread Mao Wenan
There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static? net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared. Should