Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Russell King - ARM Linux admin
On Fri, Sep 11, 2020 at 09:01:01AM -0700, Nathan Chancellor wrote: > On Fri, Sep 11, 2020 at 08:22:36AM -0700, Jakub Kicinski wrote: > > On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > > > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > > > > Ah

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > > Ah great, that is indeed cleaner, thank you for letting me know! > > Hmm, I'm not sure why gcc didn't find that. Strangely, the 0-day bot > seems to

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Nathan Chancellor
On Fri, Sep 11, 2020 at 08:22:36AM -0700, Jakub Kicinski wrote: > On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > > > Ah great, that is indeed cleaner, thank you for letting me know! > > > > Hmm,

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Russell King - ARM Linux admin
On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > On Thu, Sep 10, 2020 at 03:28:11PM -0700, David Miller wrote: > > From: Nathan Chancellor > > Date: Thu, 10 Sep 2020 10:48:27 -0700 > > > > > Clang warns (trimmed for brevity): > > > > > >

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread Nathan Chancellor
On Thu, Sep 10, 2020 at 03:28:11PM -0700, David Miller wrote: > From: Nathan Chancellor > Date: Thu, 10 Sep 2020 10:48:27 -0700 > > > Clang warns (trimmed for brevity): > > > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3073:7: warning: > > variable 'link' is used uninitialized whenever

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread David Miller
From: Nathan Chancellor Date: Thu, 10 Sep 2020 10:48:27 -0700 > Clang warns (trimmed for brevity): > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3073:7: warning: > variable 'link' is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > if

[PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread Nathan Chancellor
Clang warns (trimmed for brevity): drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3073:7: warning: variable 'link' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (val & MVPP22_XLG_STATUS_LINK_UP)