Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread Florian Fainelli
On 01/19/2018 02:06 PM, kbuild test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: >

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread Florian Fainelli
On 01/19/2018 02:06 PM, kbuild test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: >

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-stmmac-Fix-reception-of-Broadcom-switches-tags/20180120-044006 config: x86_64-randconfig-x002-201802 (attached as

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-stmmac-Fix-reception-of-Broadcom-switches-tags/20180120-044006 config: x86_64-randconfig-x002-201802 (attached as

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-17 Thread Florian Fainelli
Hi Peppe, On 01/16/2018 11:06 PM, Giuseppe CAVALLARO wrote: > Hi Florian > > for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC > Stripping, so the > core strips the Pad or FCS on frames if the value of the length field is > < 1536 bytes. > For MAC10-100 there is the Bit 8

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-17 Thread Florian Fainelli
Hi Peppe, On 01/16/2018 11:06 PM, Giuseppe CAVALLARO wrote: > Hi Florian > > for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC > Stripping, so the > core strips the Pad or FCS on frames if the value of the length field is > < 1536 bytes. > For MAC10-100 there is the Bit 8

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-16 Thread Giuseppe CAVALLARO
Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-16 Thread Giuseppe CAVALLARO
Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch

[PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-16 Thread Florian Fainelli
Broadcom tags inserted by Broadcom switches put a 4 byte header after the MAC SA and before the EtherType, which may look like some sort of 0 length LLC/SNAP packet (tcpdump and wireshark do think that way). With ACS enabled in stmmac the packets were truncated to 8 bytes on reception, whereas

[PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-16 Thread Florian Fainelli
Broadcom tags inserted by Broadcom switches put a 4 byte header after the MAC SA and before the EtherType, which may look like some sort of 0 length LLC/SNAP packet (tcpdump and wireshark do think that way). With ACS enabled in stmmac the packets were truncated to 8 bytes on reception, whereas