RE: [PATCH net-next] r8152: reduce memory copy for rx

2014-12-03 Thread Hayes Wang
Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Wednesday, December 03, 2014 3:15 PM [...] > Have you tried using more concurrent RX flows, in a possibly lossy > environment (so that TCP is forced to queue packets in out of order > queue) ? I don't do the test. I would check it next time. >

Re: [PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Eric Dumazet
On Wed, 2014-12-03 at 07:05 +, Hayes Wang wrote: > Eric Dumazet [mailto:eric.duma...@gmail.com] > > Sent: Wednesday, December 03, 2014 2:08 PM > [...] > > Better performance for what workload exactly ? > > I test it by using Chariot with 4 Tx and 4 Rx. > It has about 4% improvement. > Have

RE: [PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Hayes Wang
Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Wednesday, December 03, 2014 2:08 PM [...] > Better performance for what workload exactly ? I test it by using Chariot with 4 Tx and 4 Rx. It has about 4% improvement. > cloning in rx path has many drawbacks, with skb->truesize > being usuall

Re: [PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Eric Dumazet
On Wed, 2014-12-03 at 13:14 +0800, Hayes Wang wrote: > If the data size is more than half of the AGG_BUG_SZ, allocate a new > rx buffer and use skb_clone() to avoid the memory copy. > > The original method is that allocate the memory and copy data for each > packet in a rx buffer. The new one is t

[PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Hayes Wang
If the data size is more than half of the AGG_BUG_SZ, allocate a new rx buffer and use skb_clone() to avoid the memory copy. The original method is that allocate the memory and copy data for each packet in a rx buffer. The new one is that when the data size for a rx buffer is more than RX_THRESHOL