Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-31 Thread David Miller
From: Florian Fainelli Date: Thu, 30 Jul 2015 18:51:57 -0700 > On 30/07/15 15:51, David Miller wrote: >> From: David Miller >> Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) >> >>> This looks fine, series applied, thanks. >> >> I think your control block is too large, you'll need to rework this >

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-31 Thread Florian Fainelli
On 30/07/15 23:08, Eric Dumazet wrote: > On Thu, 2015-07-30 at 18:51 -0700, Florian Fainelli wrote: >> On 30/07/15 15:51, David Miller wrote: >>> From: David Miller >>> Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) >>> This looks fine, series applied, thanks. >>> >>> I think your control block

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Eric Dumazet
On Thu, 2015-07-30 at 18:51 -0700, Florian Fainelli wrote: > On 30/07/15 15:51, David Miller wrote: > > From: David Miller > > Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > > > >> This looks fine, series applied, thanks. > > > > I think your control block is too large, you'll need to rework this

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Chris Packham
Hi Florian, On 07/31/2015 01:51 PM, Florian Fainelli wrote: > On 30/07/15 15:51, David Miller wrote: >> From: David Miller >> Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) >> >>> This looks fine, series applied, thanks. >> >> I think your control block is too large, you'll need to rework this >> so

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Florian Fainelli
On 30/07/15 15:51, David Miller wrote: > From: David Miller > Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > >> This looks fine, series applied, thanks. > > I think your control block is too large, you'll need to rework this > somehow. So napi_gro_cb really is 48 bytes on 64-bits architectures (

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Florian Fainelli
On 30/07/15 15:51, David Miller wrote: > From: David Miller > Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > >> This looks fine, series applied, thanks. > > I think your control block is too large, you'll need to rework this > somehow. Interesting, this only seems to show up with 64-bits build,

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread David Miller
From: David Miller Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > This looks fine, series applied, thanks. I think your control block is too large, you'll need to rework this somehow. In function ‘dsa_copy_brcm_tag’, inlined from ‘bcm_sysport_desc_rx’ at drivers/net/ethernet/broadcom/bcmsys

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread David Miller
From: Florian Fainelli Date: Wed, 29 Jul 2015 15:32:37 -0700 > This patch series adds two new feature flags to allow Ethernet controllers > capable of doing Ethernet switch proprietary tag insertion/extraction to > benefit from that. > > The last two patches modify the Broadcom tag parsing code

[PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-29 Thread Florian Fainelli
Hi all, This patch series adds two new feature flags to allow Ethernet controllers capable of doing Ethernet switch proprietary tag insertion/extraction to benefit from that. The last two patches modify the Broadcom tag parsing code in DSA to utilize that feature and finally, the SYSTEMPORT contr