Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Eric W. Biederman
Joe Perches writes: > On Wed, 2013-08-28 at 13:09 -0600, Tim Gardner wrote: >> On 08/28/2013 12:51 PM, Joe Perches wrote: >> > On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: >> >> Drop a couple of ifdef/endif pairs by moving the ifdef >> >> surrounding neigh_app_ns() to the interior of

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Joe Perches
On Wed, 2013-08-28 at 13:09 -0600, Tim Gardner wrote: > On 08/28/2013 12:51 PM, Joe Perches wrote: > > On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: > >> Drop a couple of ifdef/endif pairs by moving the ifdef > >> surrounding neigh_app_ns() to the interior of neigh_app_ns(). > > [] > >>

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Eric W. Biederman
Tim Gardner writes: > Drop a couple of ifdef/endif pairs by moving the ifdef > surrounding neigh_app_ns() to the interior of neigh_app_ns(). Can we please just remove the CONFIG_ARPD option entirely. There really is no savings to keeping this option configurable and the option only removes a

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Tim Gardner
On 08/28/2013 12:51 PM, Joe Perches wrote: > On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: >> Drop a couple of ifdef/endif pairs by moving the ifdef >> surrounding neigh_app_ns() to the interior of neigh_app_ns(). > [] >> This is an admittedly trivial change. I stumbled on it while trying

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Joe Perches
On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: > Drop a couple of ifdef/endif pairs by moving the ifdef > surrounding neigh_app_ns() to the interior of neigh_app_ns(). [] > This is an admittedly trivial change. I stumbled on it while trying to figure > out why Ubuntu doesn't have

[PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Tim Gardner
Drop a couple of ifdef/endif pairs by moving the ifdef surrounding neigh_app_ns() to the interior of neigh_app_ns(). Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Cc: "Eric W. Biederman" Cc: Gao feng Cc: Joe Perches Signed-off-by:

[PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Tim Gardner
Drop a couple of ifdef/endif pairs by moving the ifdef surrounding neigh_app_ns() to the interior of neigh_app_ns(). Cc: David S. Miller da...@davemloft.net Cc: Alexey Kuznetsov kuz...@ms2.inr.ac.ru Cc: James Morris jmor...@namei.org Cc: Hideaki YOSHIFUJI yoshf...@linux-ipv6.org Cc: Patrick

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Joe Perches
On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: Drop a couple of ifdef/endif pairs by moving the ifdef surrounding neigh_app_ns() to the interior of neigh_app_ns(). [] This is an admittedly trivial change. I stumbled on it while trying to figure out why Ubuntu doesn't have CONFIG_ARPD

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Tim Gardner
On 08/28/2013 12:51 PM, Joe Perches wrote: On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: Drop a couple of ifdef/endif pairs by moving the ifdef surrounding neigh_app_ns() to the interior of neigh_app_ns(). [] This is an admittedly trivial change. I stumbled on it while trying to

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Eric W. Biederman
Tim Gardner tim.gard...@canonical.com writes: Drop a couple of ifdef/endif pairs by moving the ifdef surrounding neigh_app_ns() to the interior of neigh_app_ns(). Can we please just remove the CONFIG_ARPD option entirely. There really is no savings to keeping this option configurable and the

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Joe Perches
On Wed, 2013-08-28 at 13:09 -0600, Tim Gardner wrote: On 08/28/2013 12:51 PM, Joe Perches wrote: On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: Drop a couple of ifdef/endif pairs by moving the ifdef surrounding neigh_app_ns() to the interior of neigh_app_ns(). [] This is an

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Eric W. Biederman
Joe Perches j...@perches.com writes: On Wed, 2013-08-28 at 13:09 -0600, Tim Gardner wrote: On 08/28/2013 12:51 PM, Joe Perches wrote: On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: Drop a couple of ifdef/endif pairs by moving the ifdef surrounding neigh_app_ns() to the interior of