Re: [PATCH net-next 1/2] net: mvneta: add xmit_more support

On Tue, 2016-09-13 at 09:00 +0200, Marcin Wojtas wrote: > From: Simon Guinot > > Basing on xmit_more flag of the skb, TX descriptors can be concatenated > before flushing. This commit delay Tx descriptor flush if the queue is > running and if there is more skb's to

Re: [PATCH net-next 1/2] net: mvneta: add xmit_more support

On Tue, 2016-09-13 at 09:00 +0200, Marcin Wojtas wrote: > From: Simon Guinot > > Basing on xmit_more flag of the skb, TX descriptors can be concatenated > before flushing. This commit delay Tx descriptor flush if the queue is > running and if there is more skb's to send. > > Signed-off-by:

Re: [PATCH net-next 1/2] net: mvneta: add xmit_more support

On Tue, 2016-09-13 at 07:33 -0700, Eric Dumazet wrote: > Hi Marcin > > Well, given the above comment, and fact that MVNETA_MAX_TXD == 532, it > looks like you might add a bug if more than 256 skb are given to your > ndo_start_xmit() with skb->xmit_more = 1 > > I therefore suggest you make sure

Re: [PATCH net-next 1/2] net: mvneta: add xmit_more support

On Tue, 2016-09-13 at 07:33 -0700, Eric Dumazet wrote: > Hi Marcin > > Well, given the above comment, and fact that MVNETA_MAX_TXD == 532, it > looks like you might add a bug if more than 256 skb are given to your > ndo_start_xmit() with skb->xmit_more = 1 > > I therefore suggest you make sure

[PATCH net-next 1/2] net: mvneta: add xmit_more support

From: Simon Guinot Basing on xmit_more flag of the skb, TX descriptors can be concatenated before flushing. This commit delay Tx descriptor flush if the queue is running and if there is more skb's to send. Signed-off-by: Simon Guinot ---

[PATCH net-next 1/2] net: mvneta: add xmit_more support

From: Simon Guinot Basing on xmit_more flag of the skb, TX descriptors can be concatenated before flushing. This commit delay Tx descriptor flush if the queue is running and if there is more skb's to send. Signed-off-by: Simon Guinot --- drivers/net/ethernet/marvell/mvneta.c | 11 ---