Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-30 Thread David Miller
From: Alex Elder Date: Tue, 30 Jun 2020 17:41:44 -0500 > My point was to try to isolate the damage done to the IPA device and > driver, rather than killing the system. Excellent, then we are both on the same page.

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-30 Thread Alex Elder
On 6/30/20 2:21 PM, David Miller wrote: > From: Alex Elder > Date: Mon, 29 Jun 2020 20:09:58 -0500 > >> But the reason I was >> considering it conditional on a config option is that Qualcomm >> has a crash analysis tool that expects a BUG() call to stop the >> system so its instant state can be

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-30 Thread David Miller
From: Alex Elder Date: Mon, 29 Jun 2020 20:09:58 -0500 > But the reason I was > considering it conditional on a config option is that Qualcomm > has a crash analysis tool that expects a BUG() call to stop the > system so its instant state can be captured. I don't use this > tool, and I might be

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-29 Thread Alex Elder
On 6/29/20 8:03 PM, David Miller wrote: > Never BUG_ON() unless you absolutely cannot continue executing kernel > without corrupting memory or similar. Yes, that's basically why I don't use it. But the reason I was considering it conditional on a config option is that Qualcomm has a crash

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-29 Thread David Miller
From: Alex Elder Date: Mon, 29 Jun 2020 20:01:20 -0500 > On 6/29/20 7:35 PM, Jakub Kicinski wrote: >> On Mon, 29 Jun 2020 16:49:15 -0500 Alex Elder wrote: >>> The INIT_HOL_BLOCK_EN and INIT_HOL_BLOCK_TIMER endpoint registers >>> are only valid for RX endpoints. >>> >>> Have

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-29 Thread Alex Elder
On 6/29/20 7:35 PM, Jakub Kicinski wrote: > On Mon, 29 Jun 2020 16:49:15 -0500 Alex Elder wrote: >> The INIT_HOL_BLOCK_EN and INIT_HOL_BLOCK_TIMER endpoint registers >> are only valid for RX endpoints. >> >> Have ipa_endpoint_modem_hol_block_clear_all() skip writing these >> registers for TX

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-29 Thread Jakub Kicinski
On Mon, 29 Jun 2020 16:49:15 -0500 Alex Elder wrote: > The INIT_HOL_BLOCK_EN and INIT_HOL_BLOCK_TIMER endpoint registers > are only valid for RX endpoints. > > Have ipa_endpoint_modem_hol_block_clear_all() skip writing these > registers for TX endpoints. > > Signed-off-by: Alex Elder > --- >

[PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-29 Thread Alex Elder
The INIT_HOL_BLOCK_EN and INIT_HOL_BLOCK_TIMER endpoint registers are only valid for RX endpoints. Have ipa_endpoint_modem_hol_block_clear_all() skip writing these registers for TX endpoints. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 6 +- 1 file changed, 5