Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-06 Thread Alexei Starovoitov
On Wed, Nov 5, 2014 at 6:57 AM, Daniel Borkmann wrote: > On 11/05/2014 12:04 AM, Alexei Starovoitov wrote: >> >> On Tue, Nov 4, 2014 at 1:25 AM, Daniel Borkmann >> wrote: >>> >>> On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: the current meaning of BPF_MAP_UPDATE_ELEM syscall

Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-06 Thread Alexei Starovoitov
On Wed, Nov 5, 2014 at 6:57 AM, Daniel Borkmann dbork...@redhat.com wrote: On 11/05/2014 12:04 AM, Alexei Starovoitov wrote: On Tue, Nov 4, 2014 at 1:25 AM, Daniel Borkmann dbork...@redhat.com wrote: On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: the current meaning of

Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-05 Thread Daniel Borkmann
On 11/05/2014 12:04 AM, Alexei Starovoitov wrote: On Tue, Nov 4, 2014 at 1:25 AM, Daniel Borkmann wrote: On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: either update existing map element or create a new one. Initially the plan

Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-05 Thread Daniel Borkmann
On 11/05/2014 12:04 AM, Alexei Starovoitov wrote: On Tue, Nov 4, 2014 at 1:25 AM, Daniel Borkmann dbork...@redhat.com wrote: On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: either update existing map element or create a new one.

Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-04 Thread Alexei Starovoitov
On Tue, Nov 4, 2014 at 1:25 AM, Daniel Borkmann wrote: > > On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: >> >> the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: >> either update existing map element or create a new one. >> Initially the plan was to add a new command to handle the

Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-04 Thread Daniel Borkmann
On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: either update existing map element or create a new one. Initially the plan was to add a new command to handle the case of 'create new element if it didn't exist', but 'flags' style

Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-04 Thread Daniel Borkmann
On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: either update existing map element or create a new one. Initially the plan was to add a new command to handle the case of 'create new element if it didn't exist', but 'flags' style

Re: [PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-04 Thread Alexei Starovoitov
On Tue, Nov 4, 2014 at 1:25 AM, Daniel Borkmann dbork...@redhat.com wrote: On 11/04/2014 03:54 AM, Alexei Starovoitov wrote: the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: either update existing map element or create a new one. Initially the plan was to add a new command to

[PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-03 Thread Alexei Starovoitov
the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: either update existing map element or create a new one. Initially the plan was to add a new command to handle the case of 'create new element if it didn't exist', but 'flags' style looks cleaner and overall diff is much smaller (more

[PATCH net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command

2014-11-03 Thread Alexei Starovoitov
the current meaning of BPF_MAP_UPDATE_ELEM syscall command is: either update existing map element or create a new one. Initially the plan was to add a new command to handle the case of 'create new element if it didn't exist', but 'flags' style looks cleaner and overall diff is much smaller (more