Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-12 Thread Alexander Lobakin
Hi Eric, Eric Dumazet wrote 12.10.2019 14:18: On Sat, Oct 12, 2019 at 2:22 AM Alexander Lobakin wrote: I've generated an another solution. Considering that gro_normal_batch is very individual for every single case, maybe it would be better to make it per-NAPI (or per-netdevice) variable

Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-12 Thread Eric Dumazet
On Sat, Oct 12, 2019 at 2:22 AM Alexander Lobakin wrote: > > I've generated an another solution. Considering that gro_normal_batch > is very individual for every single case, maybe it would be better to > make it per-NAPI (or per-netdevice) variable rather than a global > across the kernel? > I

Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-12 Thread Alexander Lobakin
Alexander Lobakin wrote 11.10.2019 10:23: Hi Edward, Edward Cree wrote 10.10.2019 21:16: On 10/10/2019 15:42, Alexander Lobakin wrote: Commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs") have introduced a sysctl variable gro_normal_batch for defining a limit for

Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-11 Thread Alexander Lobakin
Hi Edward, Edward Cree wrote 10.10.2019 21:16: On 10/10/2019 15:42, Alexander Lobakin wrote: Commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs") have introduced a sysctl variable gro_normal_batch for defining a limit for listified Rx of GRO_NORMAL skbs. The initial value

Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-10 Thread Edward Cree
On 10/10/2019 15:42, Alexander Lobakin wrote: > Commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL > skbs") have introduced a sysctl variable gro_normal_batch for defining > a limit for listified Rx of GRO_NORMAL skbs. The initial value of 8 is > purely arbitrary and has been

[PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-10 Thread Alexander Lobakin
Commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs") have introduced a sysctl variable gro_normal_batch for defining a limit for listified Rx of GRO_NORMAL skbs. The initial value of 8 is purely arbitrary and has been chosen, I believe, as a minimal safe default. However,