Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Daniel Borkmann
On 03/19/2013 01:59 PM, Eric Dumazet wrote: On Tue, 2013-03-19 at 13:58 +0100, Daniel Borkmann wrote: Yes, will post them in a couple of minutes. Please target net tree for the first patch (adding thoff into struct flow_keys), so that Jason or me can fix DODGY providers. Sorry, I received

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Eric Dumazet
On Tue, 2013-03-19 at 13:58 +0100, Daniel Borkmann wrote: > Yes, will post them in a couple of minutes. > Please target net tree for the first patch (adding thoff into struct flow_keys), so that Jason or me can fix DODGY providers. Thanks -- To unsubscribe from this list: send the line

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Daniel Borkmann
On 03/19/2013 01:13 PM, Eric Dumazet wrote: On Tue, 2013-03-19 at 17:26 +0800, Jason Wang wrote: On 03/18/2013 12:13 AM, David Miller wrote: From: Eric Dumazet Date: Fri, 15 Mar 2013 19:10:51 -0700 Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ?

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Eric Dumazet
On Tue, 2013-03-19 at 17:26 +0800, Jason Wang wrote: > On 03/18/2013 12:13 AM, David Miller wrote: > > From: Eric Dumazet > > Date: Fri, 15 Mar 2013 19:10:51 -0700 > > > >> Any way we can avoid adding this to fast path, for people not using > >> macvtap and ixgbe ? > > Likewise I'd rather see

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Jason Wang
On 03/18/2013 12:13 AM, David Miller wrote: > From: Eric Dumazet > Date: Fri, 15 Mar 2013 19:10:51 -0700 > >> Any way we can avoid adding this to fast path, for people not using >> macvtap and ixgbe ? > Likewise I'd rather see macvtap be responsible for fixing this up by > setting the transport

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Jason Wang
On 03/18/2013 12:13 AM, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 15 Mar 2013 19:10:51 -0700 Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ? Likewise I'd rather see macvtap be responsible for fixing this up by setting

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Eric Dumazet
On Tue, 2013-03-19 at 17:26 +0800, Jason Wang wrote: On 03/18/2013 12:13 AM, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 15 Mar 2013 19:10:51 -0700 Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ? Likewise I'd rather

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Daniel Borkmann
On 03/19/2013 01:13 PM, Eric Dumazet wrote: On Tue, 2013-03-19 at 17:26 +0800, Jason Wang wrote: On 03/18/2013 12:13 AM, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 15 Mar 2013 19:10:51 -0700 Any way we can avoid adding this to fast path, for people not using

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Eric Dumazet
On Tue, 2013-03-19 at 13:58 +0100, Daniel Borkmann wrote: Yes, will post them in a couple of minutes. Please target net tree for the first patch (adding thoff into struct flow_keys), so that Jason or me can fix DODGY providers. Thanks -- To unsubscribe from this list: send the line

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-19 Thread Daniel Borkmann
On 03/19/2013 01:59 PM, Eric Dumazet wrote: On Tue, 2013-03-19 at 13:58 +0100, Daniel Borkmann wrote: Yes, will post them in a couple of minutes. Please target net tree for the first patch (adding thoff into struct flow_keys), so that Jason or me can fix DODGY providers. Sorry, I received

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-17 Thread David Miller
From: Eric Dumazet Date: Fri, 15 Mar 2013 19:10:51 -0700 > Any way we can avoid adding this to fast path, for people not using > macvtap and ixgbe ? Likewise I'd rather see macvtap be responsible for fixing this up by setting the transport header properly, and therfore sending well formed

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-17 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 15 Mar 2013 19:10:51 -0700 Any way we can avoid adding this to fast path, for people not using macvtap and ixgbe ? Likewise I'd rather see macvtap be responsible for fixing this up by setting the transport header properly, and therfore

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-15 Thread Eric Dumazet
On Fri, 2013-03-15 at 15:41 +0800, Jason Wang wrote: > Some drivers depends on transport_header to do packet transmission, but it was > unset in some cases (one example is macvtap driver which build skbs from > userspace and generate CHECKSUM_NONE packets). The driver may crash in those > cases

[PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-15 Thread Jason Wang
Some drivers depends on transport_header to do packet transmission, but it was unset in some cases (one example is macvtap driver which build skbs from userspace and generate CHECKSUM_NONE packets). The driver may crash in those cases since the transport_header was not valid. The problem becomes

[PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-15 Thread Jason Wang
Some drivers depends on transport_header to do packet transmission, but it was unset in some cases (one example is macvtap driver which build skbs from userspace and generate CHECKSUM_NONE packets). The driver may crash in those cases since the transport_header was not valid. The problem becomes

Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission

2013-03-15 Thread Eric Dumazet
On Fri, 2013-03-15 at 15:41 +0800, Jason Wang wrote: Some drivers depends on transport_header to do packet transmission, but it was unset in some cases (one example is macvtap driver which build skbs from userspace and generate CHECKSUM_NONE packets). The driver may crash in those cases since