Re: [PATCH net-next 2/3] virtio_net: multiqueue support

2013-01-27 Thread Jason Wang
On Tuesday, December 04, 2012 03:24:22 PM Michael S. Tsirkin wrote: > I found some bugs, see below. > Also some style nitpicking, this is not mandatory to address. Thanks for the reviewing. > > On Tue, Dec 04, 2012 at 07:07:57PM +0800, Jason Wang wrote: > > This addes multiqueue support to virtio

Re: [PATCH net-next 2/3] virtio_net: multiqueue support

2012-12-04 Thread Jason Wang
On 12/04/2012 11:11 PM, Michael S. Tsirkin wrote: > On Tue, Dec 04, 2012 at 10:45:33PM +0800, Jason Wang wrote: >> On Tuesday, December 04, 2012 03:24:22 PM Michael S. Tsirkin wrote: >>> I found some bugs, see below. >>> Also some style nitpicking, this is not mandatory to address. >> Thanks for th

Re: [PATCH net-next 2/3] virtio_net: multiqueue support

2012-12-04 Thread Michael S. Tsirkin
On Tue, Dec 04, 2012 at 10:45:33PM +0800, Jason Wang wrote: > On Tuesday, December 04, 2012 03:24:22 PM Michael S. Tsirkin wrote: > > I found some bugs, see below. > > Also some style nitpicking, this is not mandatory to address. > > Thanks for the reviewing. > > > > On Tue, Dec 04, 2012 at 07:07

Re: [PATCH net-next 2/3] virtio_net: multiqueue support

2012-12-04 Thread Jason Wang
On Tuesday, December 04, 2012 03:24:22 PM Michael S. Tsirkin wrote: > I found some bugs, see below. > Also some style nitpicking, this is not mandatory to address. Thanks for the reviewing. > > On Tue, Dec 04, 2012 at 07:07:57PM +0800, Jason Wang wrote: > > This addes multiqueue support to virtio

Re: [PATCH net-next 2/3] virtio_net: multiqueue support

2012-12-04 Thread Michael S. Tsirkin
I found some bugs, see below. Also some style nitpicking, this is not mandatory to address. On Tue, Dec 04, 2012 at 07:07:57PM +0800, Jason Wang wrote: > This addes multiqueue support to virtio_net driver. In multiple queue modes, > the > driver expects the number of queue paris is equal to the

[PATCH net-next 2/3] virtio_net: multiqueue support

2012-12-04 Thread Jason Wang
This addes multiqueue support to virtio_net driver. In multiple queue modes, the driver expects the number of queue paris is equal to the number of vcpus. To eliminate the contention bettwen vcpus and virtqueues, per-cpu virtqueue pairs were implemented through: - select the txq based on the smp p