Re: [PATCH net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

2014-05-23 Thread David Miller
From: Linus Lüssing Date: Wed, 21 May 2014 10:59:00 +0200 > + if (saddr <= br->ip4_querier.addr.u.ip4) > + goto update; It is clear to me that you should be making these comparisons in cpu endianness. Otherwise the code will handle the same situations differently on big-endian

Re: [PATCH net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

2014-05-23 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Wed, 21 May 2014 10:59:00 +0200 + if (saddr = br-ip4_querier.addr.u.ip4) + goto update; It is clear to me that you should be making these comparisons in cpu endianness. Otherwise the code will handle the same situations

[PATCH net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

2014-05-21 Thread Linus Lüssing
MLDv1 (RFC2710 section 6), MLDv2 (RFC3810 section 7.6.2), IGMPv2 (RFC2236 section 3) and IGMPv3 (RFC3376 section 6.6.2) specify that the querier with lowest source address shall become the selected querier. So far the bridge stopped its querier as soon as it heard another querier regardless of

[PATCH net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

2014-05-21 Thread Linus Lüssing
MLDv1 (RFC2710 section 6), MLDv2 (RFC3810 section 7.6.2), IGMPv2 (RFC2236 section 3) and IGMPv3 (RFC3376 section 6.6.2) specify that the querier with lowest source address shall become the selected querier. So far the bridge stopped its querier as soon as it heard another querier regardless of