RE: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-25 Thread Jose Abreu
From: Jon Hunter > I have been looking at this a bit closer and I can see the problem. What > happens is that ... > > 1. stmmac_mac_link_up() is called and priv->eee_active is set to false > 2. stmmac_eee_init() is called but because priv->eee_active is false, >timer_setup() for

Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-25 Thread Jon Hunter
On 25/06/2019 08:37, Jose Abreu wrote: > From: Jon Hunter > >> Any further feedback? I am still seeing this issue on today's -next. > > Apologies but I was in FTO. > > Is there any possibility you can just disable the ethX configuration in > the rootfs mount and manually configure it after

RE: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-25 Thread Jose Abreu
From: Jon Hunter > Any further feedback? I am still seeing this issue on today's -next. Apologies but I was in FTO. Is there any possibility you can just disable the ethX configuration in the rootfs mount and manually configure it after rootfs is done ? I just want to make sure in which

Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-20 Thread Jon Hunter
On 18/06/2019 20:44, Jon Hunter wrote: > > On 18/06/2019 16:20, Jon Hunter wrote: >> >> On 18/06/2019 11:18, Jon Hunter wrote: >>> >>> On 18/06/2019 10:46, Jose Abreu wrote: From: Jon Hunter > I am not certain but I don't believe so. We are using a static IP address > and

Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-18 Thread Jon Hunter
On 18/06/2019 16:20, Jon Hunter wrote: > > On 18/06/2019 11:18, Jon Hunter wrote: >> >> On 18/06/2019 10:46, Jose Abreu wrote: >>> From: Jon Hunter >>> I am not certain but I don't believe so. We are using a static IP address and mounting the root file-system via NFS when we see this

Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-18 Thread Jon Hunter
On 18/06/2019 11:18, Jon Hunter wrote: > > On 18/06/2019 10:46, Jose Abreu wrote: >> From: Jon Hunter >> >>> I am not certain but I don't believe so. We are using a static IP address >>> and mounting the root file-system via NFS when we see this ... >> >> Can you please add a call to

Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-18 Thread Jon Hunter
On 18/06/2019 10:46, Jose Abreu wrote: > From: Jon Hunter > >> I am not certain but I don't believe so. We are using a static IP address >> and mounting the root file-system via NFS when we see this ... > > Can you please add a call to napi_synchronize() before every > napi_disable() calls,

RE: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-18 Thread Jose Abreu
From: Jon Hunter > I am not certain but I don't believe so. We are using a static IP address > and mounting the root file-system via NFS when we see this ... Can you please add a call to napi_synchronize() before every napi_disable() calls, like this: if (queue < rx_queues_cnt) {

Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-18 Thread Jon Hunter
On 18/06/2019 10:35, Jose Abreu wrote: > From: Jon Hunter > >> I am seeing a boot regression on -next for some of our boards that have >> a synopsys ethernet controller that uses the dwmac-dwc-qos-ethernet >> driver. Git bisect is pointing to this commit, but unfortunately this >> cannot be

RE: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-18 Thread Jose Abreu
From: Jon Hunter > I am seeing a boot regression on -next for some of our boards that have > a synopsys ethernet controller that uses the dwmac-dwc-qos-ethernet > driver. Git bisect is pointing to this commit, but unfortunately this > cannot be cleanly reverted on top of -next to confirm.

Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-18 Thread Jon Hunter
On 11/06/2019 16:18, Jose Abreu wrote: > Convert everything to phylink. > > Signed-off-by: Jose Abreu > Cc: Joao Pinto > Cc: David S. Miller > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > Cc: Russell King > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Heiner Kallweit I am seeing a

[PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic

2019-06-11 Thread Jose Abreu
Convert everything to phylink. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Russell King Cc: Andrew Lunn Cc: Florian Fainelli Cc: Heiner Kallweit --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 -