Re: [PATCH net-next 3/3] ptp: idt82p33: optimize _idt82p33_adjfine

2020-11-05 Thread Richard Cochran
On Thu, Nov 05, 2020 at 02:35:56AM +0200, Vladimir Oltean wrote: > On the other hand and with all due respect, saying that it may have been > 'buggy on some archs back in the day' and then not bringing any evidence > is a bit of a strange claim to make. You're right. I made the effort to look

Re: [PATCH net-next 3/3] ptp: idt82p33: optimize _idt82p33_adjfine

2020-11-04 Thread Vladimir Oltean
On Wed, Nov 04, 2020 at 08:46:57AM -0800, Richard Cochran wrote: > On Wed, Nov 04, 2020 at 11:01:49AM -0500, min.li...@renesas.com wrote: > > From: Min Li > > > > Use div_s64 so that the neg_adj is not needed. > > Back in the day, I coded the neg_adj because there was some issue with > signed 64

Re: [PATCH net-next 3/3] ptp: idt82p33: optimize _idt82p33_adjfine

2020-11-04 Thread Richard Cochran
On Wed, Nov 04, 2020 at 11:01:49AM -0500, min.li...@renesas.com wrote: > From: Min Li > > Use div_s64 so that the neg_adj is not needed. Back in the day, I coded the neg_adj because there was some issue with signed 64 bit division that I can't recall now. Either div_s64 didn't exist or it was

[PATCH net-next 3/3] ptp: idt82p33: optimize _idt82p33_adjfine

2020-11-04 Thread min.li.xe
From: Min Li Use div_s64 so that the neg_adj is not needed. Signed-off-by: Min Li --- drivers/ptp/ptp_idt82p33.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c index b1528a0..e970379d 100644 ---