Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-31 Thread Vladimir Oltean
On Fri, Oct 30, 2020 at 06:16:31PM -0700, Jakub Kicinski wrote: > On Thu, 29 Oct 2020 04:27:37 +0200 Vladimir Oltean wrote: > > + mc = devm_kzalloc(ocelot->dev, sizeof(*mc), GFP_KERNEL); > > + if (!mc) > > + return -ENOMEM; > > + > > + mc->entry_type

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 04:27:37 +0200 Vladimir Oltean wrote: > + mc = devm_kzalloc(ocelot->dev, sizeof(*mc), GFP_KERNEL); > + if (!mc) > + return -ENOMEM; > + > + mc->entry_type = ocelot_classify_mdb(mdb->addr); > +

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-29 Thread Vladimir Oltean
On Wed, Oct 28, 2020 at 07:37:09PM -0700, Florian Fainelli wrote: > If the MDB object is programmed with SWITCHDEV_OBJ_ID_HOST_MDB then you > would need this gfp_t to be GFP_ATOMIC per > net/bridge/br_mdb.c::__br_mdb_notify, if this is a regular > SWITCHDEV_OBJ_ID_MDB then GFP_KERNEL appears to be

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-28 Thread Florian Fainelli
On 10/28/2020 7:27 PM, Vladimir Oltean wrote: > This saves a re-classification of the MDB address on deletion. > > Signed-off-by: Vladimir Oltean > --- [snip] > mc = ocelot_multicast_get(ocelot, mdb->addr, vid); > if (!mc) { > /* New entry */ > - int

[PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-28 Thread Vladimir Oltean
This saves a re-classification of the MDB address on deletion. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot.c | 51 +++--- drivers/net/ethernet/mscc/ocelot.h | 17 +- 2 files changed, 34 insertions(+), 34 deletions(-) diff --git