Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-05 Thread Victor Julien
On 04-06-2020 15:48, Willem de Bruijn wrote: > On Thu, Jun 4, 2020 at 5:47 AM Victor Julien wrote: >> >> On 02-06-2020 22:18, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: On 02-06-2020 21:38, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 3:22

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-04 Thread Willem de Bruijn
On Thu, Jun 4, 2020 at 5:47 AM Victor Julien wrote: > > On 02-06-2020 22:18, Willem de Bruijn wrote: > > On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: > >> > >> On 02-06-2020 21:38, Willem de Bruijn wrote: > >>> On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: > > On

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-04 Thread Victor Julien
On 02-06-2020 22:18, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: >> >> On 02-06-2020 21:38, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: On 02-06-2020 21:03, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 2:31

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 22:18, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: >> >> On 02-06-2020 21:38, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: On 02-06-2020 21:03, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 2:31

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Willem de Bruijn
On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: > > On 02-06-2020 21:38, Willem de Bruijn wrote: > > On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: > >> > >> On 02-06-2020 21:03, Willem de Bruijn wrote: > >>> On Tue, Jun 2, 2020 at 2:31 PM Victor Julien wrote: > On 02-06-2020

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 21:38, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: >> >> On 02-06-2020 21:03, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 2:31 PM Victor Julien wrote: On 02-06-2020 19:37, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 1:03 PM

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 21:29, Jakub Kicinski wrote: > On Tue, 2 Jun 2020 21:22:11 +0200 Victor Julien wrote: >> - receiver uses nfp (netronome) driver: TP_STATUS_CSUM_VALID set for >> every packet, including the bad TCP ones >> - receiver uses ixgbe driver: TP_STATUS_CSUM_VALID not set for the bad >>

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Willem de Bruijn
On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: > > On 02-06-2020 21:03, Willem de Bruijn wrote: > > On Tue, Jun 2, 2020 at 2:31 PM Victor Julien wrote: > >> On 02-06-2020 19:37, Willem de Bruijn wrote: > >>> On Tue, Jun 2, 2020 at 1:03 PM Victor Julien wrote: > > On 02-06-2020

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Jakub Kicinski
On Tue, 2 Jun 2020 21:22:11 +0200 Victor Julien wrote: > - receiver uses nfp (netronome) driver: TP_STATUS_CSUM_VALID set for > every packet, including the bad TCP ones > - receiver uses ixgbe driver: TP_STATUS_CSUM_VALID not set for the bad > packets. > > Again purely based on 'git grep' it

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 21:03, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 2:31 PM Victor Julien wrote: >> On 02-06-2020 19:37, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 1:03 PM Victor Julien wrote: On 02-06-2020 16:29, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 4:05 AM

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Willem de Bruijn
On Tue, Jun 2, 2020 at 2:31 PM Victor Julien wrote: > > Hi Willem, > > On 02-06-2020 19:37, Willem de Bruijn wrote: > > On Tue, Jun 2, 2020 at 1:03 PM Victor Julien wrote: > >> > >> On 02-06-2020 16:29, Willem de Bruijn wrote: > >>> On Tue, Jun 2, 2020 at 4:05 AM Victor Julien wrote: > >

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
Hi Willem, On 02-06-2020 19:37, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 1:03 PM Victor Julien wrote: >> >> On 02-06-2020 16:29, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 4:05 AM Victor Julien wrote: Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Willem de Bruijn
On Tue, Jun 2, 2020 at 1:03 PM Victor Julien wrote: > > On 02-06-2020 16:29, Willem de Bruijn wrote: > > On Tue, Jun 2, 2020 at 4:05 AM Victor Julien wrote: > >> > >> Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate > >> that the driver has completely validated the checksums in the

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 16:29, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 4:05 AM Victor Julien wrote: >> >> Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate >> that the driver has completely validated the checksums in the packet. >> >> The TP_STATUS_CSUM_UNNECESSARY flag differs from

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Willem de Bruijn
On Tue, Jun 2, 2020 at 4:05 AM Victor Julien wrote: > > Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate > that the driver has completely validated the checksums in the packet. > > The TP_STATUS_CSUM_UNNECESSARY flag differs from TP_STATUS_CSUM_VALID > in that the new flag will only

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
Need to learn how to properly do git sendpatch, apologies if i'm not following proper procedures. This v2 fixes up the doc. The output is now tested with rst2pdf and looks good. Added in a trivial related doc fixup. I wasn't completely sure if I was supposed to use tabs or spaces in rst, so did

[PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate that the driver has completely validated the checksums in the packet. The TP_STATUS_CSUM_UNNECESSARY flag differs from TP_STATUS_CSUM_VALID in that the new flag will only be set if all the layers are valid, while TP_STATUS_CSUM_VALID