Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-02-04 Thread Zoltan Kiss
On 04/02/14 19:19, Zoltan Kiss wrote: On 20/01/14 16:38, Wei Liu wrote: On Wed, Jan 15, 2014 at 05:11:07PM +, Zoltan Kiss wrote: The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive side can stall, if: -

Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-02-04 Thread Zoltan Kiss
On 20/01/14 16:38, Wei Liu wrote: On Wed, Jan 15, 2014 at 05:11:07PM +, Zoltan Kiss wrote: The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive side can stall, if: - [THREAD] xenvif_rx_action sets

Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-02-04 Thread Zoltan Kiss
On 20/01/14 16:38, Wei Liu wrote: On Wed, Jan 15, 2014 at 05:11:07PM +, Zoltan Kiss wrote: The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive side can stall, if: - [THREAD] xenvif_rx_action sets

Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-02-04 Thread Zoltan Kiss
On 04/02/14 19:19, Zoltan Kiss wrote: On 20/01/14 16:38, Wei Liu wrote: On Wed, Jan 15, 2014 at 05:11:07PM +, Zoltan Kiss wrote: The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive side can stall, if: -

Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-20 Thread Wei Liu
On Wed, Jan 15, 2014 at 05:11:07PM +, Zoltan Kiss wrote: > The recent patch to fix receive side flow control (11b57f) solved the spinning > thread problem, however caused an another one. The receive side can stall, if: > - [THREAD] xenvif_rx_action sets rx_queue_stopped to true > - [INTERRUPT]

RE: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-20 Thread Paul Durrant
> -Original Message- > From: Zoltan Kiss > Sent: 20 January 2014 12:23 > To: Ian Campbell; Wei Liu; xen-de...@lists.xenproject.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jonathan Davies > Cc: Paul Durrant > Subject: Re: [PATCH net-next v2] xen-netback

Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-20 Thread Zoltan Kiss
Any reviews on this one? It fixes an important lockup situation, so either this or some other fix should go in soon. On 15/01/14 17:11, Zoltan Kiss wrote: The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive

Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-20 Thread Zoltan Kiss
Any reviews on this one? It fixes an important lockup situation, so either this or some other fix should go in soon. On 15/01/14 17:11, Zoltan Kiss wrote: The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive

RE: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-20 Thread Paul Durrant
-Original Message- From: Zoltan Kiss Sent: 20 January 2014 12:23 To: Ian Campbell; Wei Liu; xen-de...@lists.xenproject.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jonathan Davies Cc: Paul Durrant Subject: Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo Any

Re: [PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-20 Thread Wei Liu
On Wed, Jan 15, 2014 at 05:11:07PM +, Zoltan Kiss wrote: The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive side can stall, if: - [THREAD] xenvif_rx_action sets rx_queue_stopped to true - [INTERRUPT]

[PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-15 Thread Zoltan Kiss
The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive side can stall, if: - [THREAD] xenvif_rx_action sets rx_queue_stopped to true - [INTERRUPT] interrupt happens, and sets rx_event to true - [THREAD] then

[PATCH net-next v2] xen-netback: Rework rx_work_todo

2014-01-15 Thread Zoltan Kiss
The recent patch to fix receive side flow control (11b57f) solved the spinning thread problem, however caused an another one. The receive side can stall, if: - [THREAD] xenvif_rx_action sets rx_queue_stopped to true - [INTERRUPT] interrupt happens, and sets rx_event to true - [THREAD] then