Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-20 Thread Chuanhong Guo
Hi! On Thu, Aug 20, 2020 at 7:55 AM René van Dorst wrote: > > With the current mainline code [1], the dsa code tries to detect how the MAC5 > is used. All the three modes are supported. MAC5 -> PHY0, MAC5 -> > PHY4, MAC5 -> > EXTERNAL PHY and MAC5 to external MAC. > > When MAC5 is a DSA port it

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-19 Thread René van Dorst
Quoting Landen Chao : On Wed, 2020-08-19 at 00:09 +0800, Andrew Lunn wrote: On Tue, Aug 18, 2020 at 03:14:10PM +0800, Landen Chao wrote: > Add new support for MT7531: > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > 5 giga embedded phys, 2 cpu ports, and the same

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-19 Thread Andrew Lunn
> In general, according to phy.rst, RGMII delay should be done by phy, but > some MoCA product need RGMII delay in MAC. These two requirements > conflict. Is there any suggestion to solve the conflict? Implementing the delay in the PHY is just a recommendation, not a requirement. However, as i

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-19 Thread Landen Chao
On Wed, 2020-08-19 at 00:09 +0800, Andrew Lunn wrote: > On Tue, Aug 18, 2020 at 03:14:10PM +0800, Landen Chao wrote: > > Add new support for MT7531: > > > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > > 5 giga embedded phys, 2 cpu ports, and the same MAC logic of

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-19 Thread Landen Chao
Hi Jakub, These 2 function are used in the same file only. I'll fix warnings by making 2 functions 'static' in v3. Landen On Tue, 2020-08-18 at 23:23 +0800, Jakub Kicinski wrote: [snip] > Please fix these W=1 warnings: > > ../drivers/net/dsa/mt7530.c:1976:1: warning: no previous prototype for

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-18 Thread Andrew Lunn
On Tue, Aug 18, 2020 at 03:14:10PM +0800, Landen Chao wrote: > Add new support for MT7531: > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu > port 6 only supports SGMII interface. Cpu port 5

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 15:14:10 +0800 Landen Chao wrote: > Add new support for MT7531: > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu > port 6 only supports SGMII interface. Cpu port 5 supports

[PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-18 Thread Landen Chao
Add new support for MT7531: MT7531 is the next generation of MT7530. It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu port 6 only supports SGMII interface. Cpu port 5 supports either RGMII or SGMII in different HW sku. Due to SGMII