Re: [PATCH net-next v3] net/mlx5e: Convert single case statement switch statements into if statements

2019-07-12 Thread David Miller
From: Nathan Chancellor Date: Tue, 9 Jul 2019 23:06:15 -0700 > During the review of commit 1ff2f0fa450e ("net/mlx5e: Return in default > case statement in tx_post_resync_params"), Leon and Nick pointed out > that the switch statements can be converted to single if statements > that return early

Re: [PATCH net-next v3] net/mlx5e: Convert single case statement switch statements into if statements

2019-07-10 Thread Leon Romanovsky
On Tue, Jul 09, 2019 at 11:06:15PM -0700, Nathan Chancellor wrote: > During the review of commit 1ff2f0fa450e ("net/mlx5e: Return in default > case statement in tx_post_resync_params"), Leon and Nick pointed out > that the switch statements can be converted to single if statements > that return

[PATCH net-next v3] net/mlx5e: Convert single case statement switch statements into if statements

2019-07-10 Thread Nathan Chancellor
During the review of commit 1ff2f0fa450e ("net/mlx5e: Return in default case statement in tx_post_resync_params"), Leon and Nick pointed out that the switch statements can be converted to single if statements that return early so that the code is easier to follow. Suggested-by: Leon Romanovsky