Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-30 Thread Antoine Tenart
Hi Kishon, On Wed, Aug 30, 2017 at 11:01:56AM +0530, Kishon Vijay Abraham I wrote: > > I think we should just select the mode that a particular lane has been > configured here instead of populating all the modes. But I think that doesn't > make sense since the mode is set by the consumer and the

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-30 Thread Antoine Tenart
Hi Kishon, On Wed, Aug 30, 2017 at 11:01:56AM +0530, Kishon Vijay Abraham I wrote: > > I think we should just select the mode that a particular lane has been > configured here instead of populating all the modes. But I think that doesn't > make sense since the mode is set by the consumer and the

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-30 Thread Antoine Tenart
Hi Kishon, On Wed, Aug 30, 2017 at 10:49:13AM +0530, Kishon Vijay Abraham I wrote: > On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > > + > > +static int mvebu_comphy_set_mode_sgmii(struct phy *phy, enum phy_mode mode) > > the mode need not be passed as argument here since this

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-30 Thread Antoine Tenart
Hi Kishon, On Wed, Aug 30, 2017 at 10:49:13AM +0530, Kishon Vijay Abraham I wrote: > On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > > + > > +static int mvebu_comphy_set_mode_sgmii(struct phy *phy, enum phy_mode mode) > > the mode need not be passed as argument here since this

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi, On Tuesday 29 August 2017 06:42 PM, Antoine Tenart wrote: > Hi Kishon, > > On Tue, Aug 29, 2017 at 05:55:06PM +0530, Kishon Vijay Abraham I wrote: >> On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: >>> On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: On

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi, On Tuesday 29 August 2017 06:42 PM, Antoine Tenart wrote: > Hi Kishon, > > On Tue, Aug 29, 2017 at 05:55:06PM +0530, Kishon Vijay Abraham I wrote: >> On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: >>> On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: On

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi Antoine, On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > On the CP110 unit, which can be found on various Marvell platforms such > as the 7k and 8k (currently), a comphy (common PHYs) hardware block can > be found. This block provides a number of PHYs which can be used in > various

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi Antoine, On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > On the CP110 unit, which can be found on various Marvell platforms such > as the 7k and 8k (currently), a comphy (common PHYs) hardware block can > be found. This block provides a number of PHYs which can be used in > various

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Antoine Tenart
Hi Kishon, On Tue, Aug 29, 2017 at 05:55:06PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: > > On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: > >> On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > >>> +static

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Antoine Tenart
Hi Kishon, On Tue, Aug 29, 2017 at 05:55:06PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: > > On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: > >> On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > >>> +static

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi, On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: > Hi Kishon, > > On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: >> On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: >>> >>> +config PHY_MVEBU_CP110_COMPHY >>> + tristate "Marvell CP110 comphy

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi, On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: > Hi Kishon, > > On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: >> On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: >>> >>> +config PHY_MVEBU_CP110_COMPHY >>> + tristate "Marvell CP110 comphy

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Antoine Tenart
Hi Kishon, On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: > On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > > > > +config PHY_MVEBU_CP110_COMPHY > > + tristate "Marvell CP110 comphy driver" > > + depends on ARCH_MVEBU && OF > > (ARCH_MVEBU ||

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Antoine Tenart
Hi Kishon, On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: > On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > > > > +config PHY_MVEBU_CP110_COMPHY > > + tristate "Marvell CP110 comphy driver" > > + depends on ARCH_MVEBU && OF > > (ARCH_MVEBU ||

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi Antoine, On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > On the CP110 unit, which can be found on various Marvell platforms such > as the 7k and 8k (currently), a comphy (common PHYs) hardware block can > be found. This block provides a number of PHYs which can be used in > various

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-29 Thread Kishon Vijay Abraham I
Hi Antoine, On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > On the CP110 unit, which can be found on various Marvell platforms such > as the 7k and 8k (currently), a comphy (common PHYs) hardware block can > be found. This block provides a number of PHYs which can be used in > various

[PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-28 Thread Antoine Tenart
On the CP110 unit, which can be found on various Marvell platforms such as the 7k and 8k (currently), a comphy (common PHYs) hardware block can be found. This block provides a number of PHYs which can be used in various modes by other controllers (network, SATA ...). These common PHYs must be

[PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

2017-08-28 Thread Antoine Tenart
On the CP110 unit, which can be found on various Marvell platforms such as the 7k and 8k (currently), a comphy (common PHYs) hardware block can be found. This block provides a number of PHYs which can be used in various modes by other controllers (network, SATA ...). These common PHYs must be