Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 06:59:19PM +, Min Li wrote: > > > > But what does that have to do with the misc device? > > > > Hi Greg, MFD driver is the start of everything. Once MFD driver is loading, > it will spawn 2 devices, > one is for phc driver, which is under /driver/ptp and the other

RE: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Min Li
> > But what does that have to do with the misc device? > Hi Greg, MFD driver is the start of everything. Once MFD driver is loading, it will spawn 2 devices, one is for phc driver, which is under /driver/ptp and the other one is for this misc driver. Both PHC and misc drivers are operatin

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 06:01:42PM +, Min Li wrote: > > > > That does not make sense, this is only one kernel module, with one .h file > > in > > this patch, I do not see those other files you are talking about... > > > > And if you have named registers that are identical, and yet you only w

RE: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Min Li
> > That does not make sense, this is only one kernel module, with one .h file in > this patch, I do not see those other files you are talking about... > > And if you have named registers that are identical, and yet you only work on > one device, that feels like a design flaw somewhere :) > Hi

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Greg KH
On Thu, Apr 08, 2021 at 05:26:40PM +, Min Li wrote: > > > > Again, please make this only one file. > > > Hi Greg, the 2 boards have some same named registers in idt82p33_reg.h and > idt8a340_reg.h > so if I put them all in the same file, there will be name conflicts. That does not make sen

RE: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-08 Thread Min Li
> > Again, please make this only one file. > Hi Greg, the 2 boards have some same named registers in idt82p33_reg.h and idt8a340_reg.h so if I put them all in the same file, there will be name conflicts.

Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 09:50:50PM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide support

[PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-07 Thread min.li.xe
From: Min Li This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families of timing and synchronization devices.It will be used by Renesas PTP Clock Manager for Linux (pcm4l) software to provide support to GNSS assisted partial timing support (APTS) and other networking timing funct