Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-04 Thread Florian Fainelli
On 11/3/2020 9:35 AM, Dan Murphy wrote: > Andrew > > On 11/3/20 11:18 AM, Andrew Lunn wrote: >> On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote: >>> Andrew >>> >>> On 10/30/20 3:15 PM, Andrew Lunn wrote: > +static int dp83td510_config_init(struct phy_device *phydev) > +{

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-03 Thread Andrew Lunn
> > > > drivers/net/phy/dp83td510.c:70:11: warning: symbol > > > > 'dp83td510_feature_array' was not declared. Should it be static? > > > I did not see this warning. Did you use W=1? > > I _think_ that one is W=1. All the PHY drivers are W=1 clean, and i > > want to keep it that way. And i hope

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-03 Thread Dan Murphy
Andrew On 11/3/20 11:18 AM, Andrew Lunn wrote: On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote: Andrew On 10/30/20 3:15 PM, Andrew Lunn wrote: +static int dp83td510_config_init(struct phy_device *phydev) +{ + struct dp83td510_private *dp83td510 = phydev->priv; + int

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-03 Thread Dan Murphy
Andrew On 11/3/20 11:21 AM, Andrew Lunn wrote: On Tue, Nov 03, 2020 at 11:09:44AM -0600, Dan Murphy wrote: Hello On 10/30/20 6:03 PM, Jakub Kicinski wrote: On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote: The DP83TD510E is an ultra-low power Ethernet physical layer transceiver that

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-03 Thread Andrew Lunn
On Tue, Nov 03, 2020 at 11:09:44AM -0600, Dan Murphy wrote: > Hello > > On 10/30/20 6:03 PM, Jakub Kicinski wrote: > > On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote: > > > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver > > > that supports 10M single pair cable. > >

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-03 Thread Andrew Lunn
On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote: > Andrew > > On 10/30/20 3:15 PM, Andrew Lunn wrote: > > > +static int dp83td510_config_init(struct phy_device *phydev) > > > +{ > > > + struct dp83td510_private *dp83td510 = phydev->priv; > > > + int mst_slave_cfg; > > > + int ret = 0;

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-03 Thread Dan Murphy
Hello On 10/30/20 6:03 PM, Jakub Kicinski wrote: On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote: The DP83TD510E is an ultra-low power Ethernet physical layer transceiver that supports 10M single pair cable. The device supports both 2.4-V p2p and 1-V p2p output voltage as defined by IEEE

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-03 Thread Dan Murphy
Andrew On 10/30/20 3:15 PM, Andrew Lunn wrote: +static int dp83td510_config_init(struct phy_device *phydev) +{ + struct dp83td510_private *dp83td510 = phydev->priv; + int mst_slave_cfg; + int ret = 0; + + if (phy_interface_is_rgmii(phydev)) { + if

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-10-31 Thread Ioana Ciornei
On Fri, Oct 30, 2020 at 12:29:50PM -0500, Dan Murphy wrote: > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver > that supports 10M single pair cable. > > The device supports both 2.4-V p2p and 1-V p2p output voltage as defined > by IEEE 802.3cg 10Base-T1L specfications.

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-10-30 Thread Jakub Kicinski
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote: > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver > that supports 10M single pair cable. > > The device supports both 2.4-V p2p and 1-V p2p output voltage as defined > by IEEE 802.3cg 10Base-T1L specfications. These

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-10-30 Thread Andrew Lunn
> +static int dp83td510_config_init(struct phy_device *phydev) > +{ > + struct dp83td510_private *dp83td510 = phydev->priv; > + int mst_slave_cfg; > + int ret = 0; > + > + if (phy_interface_is_rgmii(phydev)) { > + if (dp83td510->rgmii_delay) { > +

[PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-10-30 Thread Dan Murphy
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver that supports 10M single pair cable. The device supports both 2.4-V p2p and 1-V p2p output voltage as defined by IEEE 802.3cg 10Base-T1L specfications. These modes can be forced via the device tree or the device is defaulted