RE: [PATCH net-next v4 0/2] r8152: save EEE

2019-08-25 Thread Hayes Wang
Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, August 23, 2019 10:37 PM [...] > Hi Hayes > > That was 3 revisions of the patches in less than 30 minutes. Slow > down, take your time, review your work yourself before posting it, > etc. > > Aim for no more than one revision, posted to the

Re: [PATCH net-next v4 0/2] r8152: save EEE

2019-08-23 Thread David Miller
From: Hayes Wang Date: Fri, 23 Aug 2019 15:33:39 +0800 > v4: > For patch #2, remove redundant calling of "ocp_reg_write(tp, OCP_EEE_ADV, 0)". > > v3: > For patch #2, fix the mistake caused by copying and pasting. > > v2: > Adjust patch #1. The EEE has been disabled in the beginning of >

Re: [PATCH net-next v4 0/2] r8152: save EEE

2019-08-23 Thread Andrew Lunn
On Fri, Aug 23, 2019 at 03:33:39PM +0800, Hayes Wang wrote: > v4: > For patch #2, remove redundant calling of "ocp_reg_write(tp, OCP_EEE_ADV, 0)". > > v3: > For patch #2, fix the mistake caused by copying and pasting. > > v2: > Adjust patch #1. The EEE has been disabled in the beginning of >

[PATCH net-next v4 0/2] r8152: save EEE

2019-08-23 Thread Hayes Wang
v4: For patch #2, remove redundant calling of "ocp_reg_write(tp, OCP_EEE_ADV, 0)". v3: For patch #2, fix the mistake caused by copying and pasting. v2: Adjust patch #1. The EEE has been disabled in the beginning of r8153_hw_phy_cfg() and r8153b_hw_phy_cfg(), so only check if it is necessary to