Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Richard Cochran
On Fri, Dec 04, 2020 at 03:00:50AM +0200, Vladimir Oltean wrote: > On Thu, Dec 03, 2020 at 04:45:56PM -0800, Richard Cochran wrote: > > Yes, that would make sense. It would bring sysfs back to feature > > parity with the ioctls. > > Which is a good thing? Yes, of course it is. I'm sorry I didn'

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Vladimir Oltean
On Thu, Dec 03, 2020 at 04:45:56PM -0800, Richard Cochran wrote: > On Thu, Dec 03, 2020 at 04:36:26PM +0100, Christian Eggers wrote: > > Should ptp_sysfs be extended with a "pulse" attribute with calls > > enable() with only PTP_PEROUT_DUTY_CYCLE set? > > Yes, that would make sense. It would bring

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Richard Cochran
On Thu, Dec 03, 2020 at 04:36:26PM +0100, Christian Eggers wrote: > Should ptp_sysfs be extended with a "pulse" attribute with calls > enable() with only PTP_PEROUT_DUTY_CYCLE set? Yes, that would make sense. It would bring sysfs back to feature parity with the ioctls. Thanks, Richard

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Christian Eggers
On Thursday, 3 December 2020, 16:52:46 CET, Vladimir Oltean wrote: > On Thu, 3 Dec 2020 at 17:36, Christian Eggers wrote: > > Should ptp_sysfs be extended with a "pulse" attribute with calls > > enable() with only PTP_PEROUT_DUTY_CYCLE set? > > Use tools/testing/selftests/ptp/testptp. Thanks for

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Vladimir Oltean
On Thu, 3 Dec 2020 at 17:36, Christian Eggers wrote: > Should ptp_sysfs be extended with a "pulse" attribute with calls > enable() with only PTP_PEROUT_DUTY_CYCLE set? Use tools/testing/selftests/ptp/testptp.

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Christian Eggers
On Thursday, 3 December 2020, 15:12:55 CET, Richard Cochran wrote: > On Thu, Dec 03, 2020 at 11:21:17AM +0100, Christian Eggers wrote: > > The KSZ9563 has a Trigger Output Unit (TOU) which can be used to > > generate periodic signals. > > > > The pulse length can be altered via a device attribute.

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Richard Cochran
On Thu, Dec 03, 2020 at 11:21:17AM +0100, Christian Eggers wrote: > The KSZ9563 has a Trigger Output Unit (TOU) which can be used to > generate periodic signals. > > The pulse length can be altered via a device attribute. Device tree is the wrong place for that. Aren't you using PTP_PEROUT_DUTY_

[PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Christian Eggers
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to generate periodic signals. The pulse length can be altered via a device attribute. Tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- Changes in v4: -- - 80 chars per line - reverse christmas tre