Re: [PATCH net-next v7 8/9] xen-netback: Timeout packets in RX path

2014-03-13 Thread Ian Campbell
On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: > @@ -557,12 +577,25 @@ void xenvif_disconnect(struct xenvif *vif) > void xenvif_free(struct xenvif *vif) > { > int i, unmap_timeout = 0; > + /* Here we want to avoid timeout messages if an skb can be legitimatly "legitimately" >

Re: [PATCH net-next v7 8/9] xen-netback: Timeout packets in RX path

2014-03-13 Thread Ian Campbell
On Thu, 2014-03-06 at 21:48 +, Zoltan Kiss wrote: @@ -557,12 +577,25 @@ void xenvif_disconnect(struct xenvif *vif) void xenvif_free(struct xenvif *vif) { int i, unmap_timeout = 0; + /* Here we want to avoid timeout messages if an skb can be legitimatly legitimately + *

[PATCH net-next v7 8/9] xen-netback: Timeout packets in RX path

2014-03-06 Thread Zoltan Kiss
A malicious or buggy guest can leave its queue filled indefinitely, in which case qdisc start to queue packets for that VIF. If those packets came from an another guest, it can block its slots and prevent shutdown. To avoid that, we make sure the queue is drained in every 10 seconds. The QDisc

[PATCH net-next v7 8/9] xen-netback: Timeout packets in RX path

2014-03-06 Thread Zoltan Kiss
A malicious or buggy guest can leave its queue filled indefinitely, in which case qdisc start to queue packets for that VIF. If those packets came from an another guest, it can block its slots and prevent shutdown. To avoid that, we make sure the queue is drained in every 10 seconds. The QDisc