Re: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-11 Thread maowenan
On 2019/9/11 22:39, Marcelo Ricardo Leitner wrote: > On Wed, Sep 11, 2019 at 11:30:08AM -0300, Marcelo Ricardo Leitner wrote: >> On Wed, Sep 11, 2019 at 11:30:38AM +0300, Dan Carpenter wrote: >>> On Wed, Sep 11, 2019 at 09:30:47AM +0800, maowenan wrote: On 2019/9/11 3:22, Dan

Re: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-11 Thread Marcelo Ricardo Leitner
On Wed, Sep 11, 2019 at 11:30:08AM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Sep 11, 2019 at 11:30:38AM +0300, Dan Carpenter wrote: > > On Wed, Sep 11, 2019 at 09:30:47AM +0800, maowenan wrote: > > > > > > > > > On 2019/9/11 3:22, Dan Carpenter wrote: > > > > On Tue, Sep 10, 2019 at

Re: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-11 Thread Marcelo Ricardo Leitner
On Wed, Sep 11, 2019 at 11:30:38AM +0300, Dan Carpenter wrote: > On Wed, Sep 11, 2019 at 09:30:47AM +0800, maowenan wrote: > > > > > > On 2019/9/11 3:22, Dan Carpenter wrote: > > > On Tue, Sep 10, 2019 at 09:57:10PM +0300, Dan Carpenter wrote: > > >> On Tue, Sep 10, 2019 at 03:13:42PM +0800, Mao

Re: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-11 Thread Dan Carpenter
On Wed, Sep 11, 2019 at 09:30:47AM +0800, maowenan wrote: > > > On 2019/9/11 3:22, Dan Carpenter wrote: > > On Tue, Sep 10, 2019 at 09:57:10PM +0300, Dan Carpenter wrote: > >> On Tue, Sep 10, 2019 at 03:13:42PM +0800, Mao Wenan wrote: > >>> There are more parentheses in if clause when call

Re: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-10 Thread maowenan
On 2019/9/11 3:22, Dan Carpenter wrote: > On Tue, Sep 10, 2019 at 09:57:10PM +0300, Dan Carpenter wrote: >> On Tue, Sep 10, 2019 at 03:13:42PM +0800, Mao Wenan wrote: >>> There are more parentheses in if clause when call sctp_get_port_local >>> in sctp_do_bind, and redundant assignment to

Re: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-10 Thread Dan Carpenter
On Tue, Sep 10, 2019 at 09:57:10PM +0300, Dan Carpenter wrote: > On Tue, Sep 10, 2019 at 03:13:42PM +0800, Mao Wenan wrote: > > There are more parentheses in if clause when call sctp_get_port_local > > in sctp_do_bind, and redundant assignment to 'ret'. This patch is to > > do cleanup. > > > >

Re: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-10 Thread Dan Carpenter
On Tue, Sep 10, 2019 at 03:13:42PM +0800, Mao Wenan wrote: > There are more parentheses in if clause when call sctp_get_port_local > in sctp_do_bind, and redundant assignment to 'ret'. This patch is to > do cleanup. > > Signed-off-by: Mao Wenan > --- > net/sctp/socket.c | 3 +-- > 1 file

[PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local

2019-09-10 Thread Mao Wenan
There are more parentheses in if clause when call sctp_get_port_local in sctp_do_bind, and redundant assignment to 'ret'. This patch is to do cleanup. Signed-off-by: Mao Wenan --- net/sctp/socket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sctp/socket.c