Re: [PATCH net V2] vhost: log dirty page correctly

2019-01-10 Thread Jason Wang
On 2019/1/10 下午10:07, Michael S. Tsirkin wrote: On Thu, Jan 10, 2019 at 08:37:17PM +0800, Jason Wang wrote: On 2019/1/9 下午10:25, Michael S. Tsirkin wrote: On Wed, Jan 09, 2019 at 03:29:47PM +0800, Jason Wang wrote: Vhost dirty page logging API is designed to sync through GPA. But we try to

Re: [PATCH net V2] vhost: log dirty page correctly

2019-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2019 at 08:37:17PM +0800, Jason Wang wrote: > > On 2019/1/9 下午10:25, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 03:29:47PM +0800, Jason Wang wrote: > > > Vhost dirty page logging API is designed to sync through GPA. But we > > > try to log GIOVA when device IOTLB is

Re: [PATCH net V2] vhost: log dirty page correctly

2019-01-10 Thread Jason Wang
On 2019/1/9 下午10:25, Michael S. Tsirkin wrote: On Wed, Jan 09, 2019 at 03:29:47PM +0800, Jason Wang wrote: Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To solve

Re: [PATCH net V2] vhost: log dirty page correctly

2019-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2019 at 03:29:47PM +0800, Jason Wang wrote: > Vhost dirty page logging API is designed to sync through GPA. But we > try to log GIOVA when device IOTLB is enabled. This is wrong and may > lead to missing data after migration. > > To solve this issue, when logging with device IOTLB

[PATCH net V2] vhost: log dirty page correctly

2019-01-08 Thread Jason Wang
Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To solve this issue, when logging with device IOTLB enabled, we will: 1) reuse the device IOTLB translation result of