Re: [PATCH net v1] lan743x: fix "BUG: invalid wait context" when setting rx mode

2020-11-10 Thread Sven Van Asbroeck
On Tue, Nov 10, 2020 at 8:55 PM Jakub Kicinski wrote: > > Please remember about fixes tags Will do in the future- I posted this patch before we had this conversation about the need for Fixes tags in net. > > Applied, thanks! Thank you !

Re: [PATCH net v1] lan743x: fix "BUG: invalid wait context" when setting rx mode

2020-11-10 Thread Jakub Kicinski
On Mon, 9 Nov 2020 15:38:28 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > In the net core, the struct net_device_ops -> ndo_set_rx_mode() > callback is called with the dev->addr_list_lock spinlock held. > > However, this driver's ndo_set_rx_mode callback eventually calls >

[PATCH net v1] lan743x: fix "BUG: invalid wait context" when setting rx mode

2020-11-09 Thread Sven Van Asbroeck
From: Sven Van Asbroeck In the net core, the struct net_device_ops -> ndo_set_rx_mode() callback is called with the dev->addr_list_lock spinlock held. However, this driver's ndo_set_rx_mode callback eventually calls lan743x_dp_write(), which acquires a mutex. Mutex acquisition may sleep, and