Re: [PATCH net v2] net: Clarify the difference between hard_header_len and needed_headroom

2020-09-10 Thread Xie He
OK. I'll make the changes you suggested and resubmit the patch. Thanks! I'll drop the change to netdevice.h and the check for dev_hard_header's return value. If there's still a need for something similar to these, we can do them in a separate patch.

Re: [PATCH net v2] net: Clarify the difference between hard_header_len and needed_headroom

2020-09-10 Thread Willem de Bruijn
On Thu, Sep 10, 2020 at 7:44 AM Xie He wrote: > > The difference between hard_header_len and needed_headroom has long been > confusing to driver developers. Let's clarify it. > > The understanding on this issue in this patch is based on the following > reasons: > > 1. > > In af_packet.c, the

[PATCH net v2] net: Clarify the difference between hard_header_len and needed_headroom

2020-09-09 Thread Xie He
The difference between hard_header_len and needed_headroom has long been confusing to driver developers. Let's clarify it. The understanding on this issue in this patch is based on the following reasons: 1. In af_packet.c, the function packet_snd first reserves a headroom of length