Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Jakub Kicinski
On Mon, 4 Jan 2021 15:18:50 +0100 Andrew Lunn wrote: > On Mon, Jan 04, 2021 at 10:38:02AM +, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > - if (!clk) > > + if (!bp->tx_clk ||

Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2021 at 10:38:02AM +, Charles Keepax wrote: > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > macb_set_tx_clk were gated on the presence of this flag. > > - if (!clk) > + if (!bp->tx_clk || !(bp->caps & MACB_CAPS_CLK_HW_CHG)) > > However the flag was not

Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Claudiu.Beznea
Hi Charles, On 04.01.2021 12:38, Charles Keepax wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > macb_set_tx_clk were gated on the presence of this flag. > > - if (!clk) >

[PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Charles Keepax
A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of macb_set_tx_clk were gated on the presence of this flag. - if (!clk) + if (!bp->tx_clk || !(bp->caps & MACB_CAPS_CLK_HW_CHG)) However the flag was not added to anything other than the new sama7g5_gem, turning that function call into