Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-18 Thread Petr Mladek
On Fri 2020-09-18 14:32:41, Rasmus Villemoes wrote: > On 18/09/2020 14.13, Petr Mladek wrote: > > On Fri 2020-09-18 08:16:37, Rasmus Villemoes wrote: > >> On 17/09/2020 15.16, John Ogness wrote: > >> > >>> if (dev->class) > >>> subsys = dev->class->name; > >>> else if (dev->bus) > >>>

Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-18 Thread Rasmus Villemoes
On 18/09/2020 14.13, Petr Mladek wrote: > On Fri 2020-09-18 08:16:37, Rasmus Villemoes wrote: >> On 17/09/2020 15.16, John Ogness wrote: >> >>> if (dev->class) >>> subsys = dev->class->name; >>> else if (dev->bus) >>> subsys = dev->bus->name; >>> else >>> -

Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-18 Thread Petr Mladek
On Fri 2020-09-18 08:16:37, Rasmus Villemoes wrote: > On 17/09/2020 15.16, John Ogness wrote: > > > if (dev->class) > > subsys = dev->class->name; > > else if (dev->bus) > > subsys = dev->bus->name; > > else > > - return 0; > > + return; > >

Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-18 Thread Petr Mladek
On Thu 2020-09-17 15:22:43, John Ogness wrote: > Dictionaries are only used for SUBSYSTEM and DEVICE properties. The > current implementation stores the property names each time they are > used. This requires more space than otherwise necessary. Also, > because the dictionary entries are currently

Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-17 Thread Rasmus Villemoes
On 17/09/2020 15.16, John Ogness wrote: > if (dev->class) > subsys = dev->class->name; > else if (dev->bus) > subsys = dev->bus->name; > else > - return 0; > + return; > > - pos += snprintf(hdr + pos, hdrlen - pos, "SUBSYS

[PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

2020-09-17 Thread John Ogness
Dictionaries are only used for SUBSYSTEM and DEVICE properties. The current implementation stores the property names each time they are used. This requires more space than otherwise necessary. Also, because the dictionary entries are currently considered optional, it cannot be relied upon that they