Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri, 6 Apr 2018 12:02:36 +0200 Michal Hocko wrote: > On Wed 29-11-17 17:04:46, Michal Hocko wrote: > [...] > > From 000bb422fe07adbfa8cd8ed953b18f48647a45d6 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Wed, 29 Nov 2017 17:02:33 +0100 > >

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri, 6 Apr 2018 12:02:36 +0200 Michal Hocko wrote: > On Wed 29-11-17 17:04:46, Michal Hocko wrote: > [...] > > From 000bb422fe07adbfa8cd8ed953b18f48647a45d6 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Wed, 29 Nov 2017 17:02:33 +0100 > > Subject: [PATCH] mm: drop VM_BUG_ON from

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Wed 29-11-17 17:04:46, Michal Hocko wrote: [...] > From 000bb422fe07adbfa8cd8ed953b18f48647a45d6 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Wed, 29 Nov 2017 17:02:33 +0100 > Subject: [PATCH] mm: drop VM_BUG_ON from __get_free_pages > > There is no real reason to

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Wed 29-11-17 17:04:46, Michal Hocko wrote: [...] > From 000bb422fe07adbfa8cd8ed953b18f48647a45d6 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Wed, 29 Nov 2017 17:02:33 +0100 > Subject: [PATCH] mm: drop VM_BUG_ON from __get_free_pages > > There is no real reason to blow up just

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri 15-12-17 12:57:35, Andrew Morton wrote: > On Fri, 15 Dec 2017 10:36:18 +0100 Michal Hocko wrote: > > > > > > > > > So do we care and I will resend the patch in that case or I just drop > > > > this from my patch queue? > > > > > > Well.. I still think that silently

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri 15-12-17 12:57:35, Andrew Morton wrote: > On Fri, 15 Dec 2017 10:36:18 +0100 Michal Hocko wrote: > > > > > > > > > So do we care and I will resend the patch in that case or I just drop > > > > this from my patch queue? > > > > > > Well.. I still think that silently accepting bad input

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri, 15 Dec 2017 10:36:18 +0100 Michal Hocko wrote: > > > > > > So do we care and I will resend the patch in that case or I just drop > > > this from my patch queue? > > > > Well.. I still think that silently accepting bad input would be bad > > practice. If we can just

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri, 15 Dec 2017 10:36:18 +0100 Michal Hocko wrote: > > > > > > So do we care and I will resend the patch in that case or I just drop > > > this from my patch queue? > > > > Well.. I still think that silently accepting bad input would be bad > > practice. If we can just delete the

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu 14-12-17 12:33:09, Andrew Morton wrote: > On Thu, 14 Dec 2017 15:06:08 +0100 Michal Hocko wrote: > > > On Fri 01-12-17 12:18:45, Michal Hocko wrote: > > > On Fri 01-12-17 08:24:14, Michal Hocko wrote: > > > > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > > > > On

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu 14-12-17 12:33:09, Andrew Morton wrote: > On Thu, 14 Dec 2017 15:06:08 +0100 Michal Hocko wrote: > > > On Fri 01-12-17 12:18:45, Michal Hocko wrote: > > > On Fri 01-12-17 08:24:14, Michal Hocko wrote: > > > > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > > > > On Thu, 30 Nov 2017

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu, 14 Dec 2017 15:06:08 +0100 Michal Hocko wrote: > On Fri 01-12-17 12:18:45, Michal Hocko wrote: > > On Fri 01-12-17 08:24:14, Michal Hocko wrote: > > > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > > > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu, 14 Dec 2017 15:06:08 +0100 Michal Hocko wrote: > On Fri 01-12-17 12:18:45, Michal Hocko wrote: > > On Fri 01-12-17 08:24:14, Michal Hocko wrote: > > > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > > > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko > > > > wrote: > > > > > > > >

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri 01-12-17 12:18:45, Michal Hocko wrote: > On Fri 01-12-17 08:24:14, Michal Hocko wrote: > > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > > > > > > > mm... So we have a caller which hopes to be getting

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri 01-12-17 12:18:45, Michal Hocko wrote: > On Fri 01-12-17 08:24:14, Michal Hocko wrote: > > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > > > > > > > mm... So we have a caller which hopes to be getting highmem pages but > >

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri 01-12-17 08:24:14, Michal Hocko wrote: > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > > > > > mm... So we have a caller which hopes to be getting highmem pages but > > > > isn't. Caller then proceeds to

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Fri 01-12-17 08:24:14, Michal Hocko wrote: > On Thu 30-11-17 13:17:06, Andrew Morton wrote: > > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > > > > > mm... So we have a caller which hopes to be getting highmem pages but > > > > isn't. Caller then proceeds to pointlessly kmap

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu 30-11-17 13:17:06, Andrew Morton wrote: > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > > > mm... So we have a caller which hopes to be getting highmem pages but > > > isn't. Caller then proceeds to pointlessly kmap the page and wonders > > > why it isn't

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu 30-11-17 13:17:06, Andrew Morton wrote: > On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > > > mm... So we have a caller which hopes to be getting highmem pages but > > > isn't. Caller then proceeds to pointlessly kmap the page and wonders > > > why it isn't getting as much

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > mm... So we have a caller which hopes to be getting highmem pages but > > isn't. Caller then proceeds to pointlessly kmap the page and wonders > > why it isn't getting as much memory as it would like on 32-bit

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Thu, 30 Nov 2017 07:53:35 +0100 Michal Hocko wrote: > > mm... So we have a caller which hopes to be getting highmem pages but > > isn't. Caller then proceeds to pointlessly kmap the page and wonders > > why it isn't getting as much memory as it would like on 32-bit systems, > > etc. > >

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Wed 29-11-17 13:41:59, Andrew Morton wrote: > On Wed, 29 Nov 2017 17:04:46 +0100 Michal Hocko wrote: > > > On Mon 27-11-17 12:33:41, Michal Hocko wrote: > > > On Mon 27-11-17 19:09:24, JianKang Chen wrote: > > > > From: Jiankang Chen > > > > > >

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Wed 29-11-17 13:41:59, Andrew Morton wrote: > On Wed, 29 Nov 2017 17:04:46 +0100 Michal Hocko wrote: > > > On Mon 27-11-17 12:33:41, Michal Hocko wrote: > > > On Mon 27-11-17 19:09:24, JianKang Chen wrote: > > > > From: Jiankang Chen > > > > > > > > __get_free_pages will return an virtual

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Wed, 29 Nov 2017 17:04:46 +0100 Michal Hocko wrote: > On Mon 27-11-17 12:33:41, Michal Hocko wrote: > > On Mon 27-11-17 19:09:24, JianKang Chen wrote: > > > From: Jiankang Chen > > > > > > __get_free_pages will return an virtual address, > > >

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Wed, 29 Nov 2017 17:04:46 +0100 Michal Hocko wrote: > On Mon 27-11-17 12:33:41, Michal Hocko wrote: > > On Mon 27-11-17 19:09:24, JianKang Chen wrote: > > > From: Jiankang Chen > > > > > > __get_free_pages will return an virtual address, > > > but it is not just 32-bit address, for example

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Mon 27-11-17 12:33:41, Michal Hocko wrote: > On Mon 27-11-17 19:09:24, JianKang Chen wrote: > > From: Jiankang Chen > > > > __get_free_pages will return an virtual address, > > but it is not just 32-bit address, for example a 64-bit system. > > And this comment

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Mon 27-11-17 12:33:41, Michal Hocko wrote: > On Mon 27-11-17 19:09:24, JianKang Chen wrote: > > From: Jiankang Chen > > > > __get_free_pages will return an virtual address, > > but it is not just 32-bit address, for example a 64-bit system. > > And this comment really confuse new bigenner

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Mon 27-11-17 19:09:24, JianKang Chen wrote: > From: Jiankang Chen > > __get_free_pages will return an virtual address, > but it is not just 32-bit address, for example a 64-bit system. > And this comment really confuse new bigenner of mm. s@bigenner@beginner@

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On Mon 27-11-17 19:09:24, JianKang Chen wrote: > From: Jiankang Chen > > __get_free_pages will return an virtual address, > but it is not just 32-bit address, for example a 64-bit system. > And this comment really confuse new bigenner of mm. s@bigenner@beginner@ Anyway, do we really need a

[PATCH resend] mm/page_alloc: fix comment is __get_free_pages

From: Jiankang Chen __get_free_pages will return an virtual address, but it is not just 32-bit address, for example a 64-bit system. And this comment really confuse new bigenner of mm. reported-by: Hanjun Guo Signed-off-by: Jiankang Chen

[PATCH resend] mm/page_alloc: fix comment is __get_free_pages

From: Jiankang Chen __get_free_pages will return an virtual address, but it is not just 32-bit address, for example a 64-bit system. And this comment really confuse new bigenner of mm. reported-by: Hanjun Guo Signed-off-by: Jiankang Chen --- mm/page_alloc.c | 2 +- 1 file changed, 1

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On 11/25/2017 12:50 PM, JianKang Chen wrote: > From: Jiankang Chen > > __get_free_pages will return an 64bit address in 64bit System > like arm64 or x86_64. And this comment really confuse new bigenner of > mm. Normally its not 64 bit virtual address though CPU

Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

On 11/25/2017 12:50 PM, JianKang Chen wrote: > From: Jiankang Chen > > __get_free_pages will return an 64bit address in 64bit System > like arm64 or x86_64. And this comment really confuse new bigenner of > mm. Normally its not 64 bit virtual address though CPU architecture supports 64 bits.

[PATCH resend] mm/page_alloc: fix comment is __get_free_pages

From: Jiankang Chen __get_free_pages will return an 64bit address in 64bit System like arm64 or x86_64. And this comment really confuse new bigenner of mm. Signed-off-by: Jiankang Chen --- mm/page_alloc.c | 2 +- 1 file changed, 1

[PATCH resend] mm/page_alloc: fix comment is __get_free_pages

From: Jiankang Chen __get_free_pages will return an 64bit address in 64bit System like arm64 or x86_64. And this comment really confuse new bigenner of mm. Signed-off-by: Jiankang Chen --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c