Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-22 Thread Jens Axboe
On Thu, Apr 21 2005, James Bottomley wrote: > On Thu, 2005-04-21 at 08:10 +0200, Jens Axboe wrote: > > I wondered about this action recently myself. What is the point in > > requeueing this request, only to call scsi_run_queue() -> > > blk_run_queue() -> issue same request. If the point really is

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-22 Thread Jens Axboe
On Thu, Apr 21 2005, James Bottomley wrote: On Thu, 2005-04-21 at 08:10 +0200, Jens Axboe wrote: I wondered about this action recently myself. What is the point in requeueing this request, only to call scsi_run_queue() - blk_run_queue() - issue same request. If the point really is to

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-21 Thread James Bottomley
On Thu, 2005-04-21 at 08:10 +0200, Jens Axboe wrote: > I wondered about this action recently myself. What is the point in > requeueing this request, only to call scsi_run_queue() -> > blk_run_queue() -> issue same request. If the point really is to reissue > the request immediately, I can think of

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-21 Thread Jens Axboe
On Wed, Apr 20 2005, James Bottomley wrote: > On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: > > -* Insert this command at the head of the queue for it's device. > > -* It will go before all other commands that are already in the queue. > > -* > > -* NOTE: there is magic here

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-21 Thread Jens Axboe
On Wed, Apr 20 2005, James Bottomley wrote: On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: -* Insert this command at the head of the queue for it's device. -* It will go before all other commands that are already in the queue. -* -* NOTE: there is magic here about the

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-21 Thread James Bottomley
On Thu, 2005-04-21 at 08:10 +0200, Jens Axboe wrote: I wondered about this action recently myself. What is the point in requeueing this request, only to call scsi_run_queue() - blk_run_queue() - issue same request. If the point really is to reissue the request immediately, I can think of many

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread Tejun Heo
Hello, James. This is the modified patch with the comment (slightly modified). With this patch, the next patch in this patchset complains about line offset but it's okay. Thanks. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Index: scsi-reqfn-export/drivers/scsi/scsi_lib.c

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread Tejun Heo
James Bottomley wrote: > On Thu, 2005-04-21 at 09:20 +0900, Tejun Heo wrote: > >> Hello, James. >> >>James Bottomley wrote: >> >>>On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: >>> >>> -* Insert this command at the head of the queue for it's device. -* It will go before all

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread James Bottomley
On Thu, 2005-04-21 at 09:20 +0900, Tejun Heo wrote: > Hello, James. > > James Bottomley wrote: > > On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: > > > >>-* Insert this command at the head of the queue for it's device. > >>-* It will go before all other commands that are already

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread Tejun Heo
Hello, James. James Bottomley wrote: On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: - * Insert this command at the head of the queue for it's device. - * It will go before all other commands that are already in the queue. - * - * NOTE: there is magic here about the way the queue is

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread James Bottomley
On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: > - * Insert this command at the head of the queue for it's device. > - * It will go before all other commands that are already in the queue. > - * > - * NOTE: there is magic here about the way the queue is plugged if > -

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread James Bottomley
On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: - * Insert this command at the head of the queue for it's device. - * It will go before all other commands that are already in the queue. - * - * NOTE: there is magic here about the way the queue is plugged if - * we

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread Tejun Heo
Hello, James. James Bottomley wrote: On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: - * Insert this command at the head of the queue for it's device. - * It will go before all other commands that are already in the queue. - * - * NOTE: there is magic here about the way the queue is

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread James Bottomley
On Thu, 2005-04-21 at 09:20 +0900, Tejun Heo wrote: Hello, James. James Bottomley wrote: On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: -* Insert this command at the head of the queue for it's device. -* It will go before all other commands that are already in the queue.

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread Tejun Heo
James Bottomley wrote: On Thu, 2005-04-21 at 09:20 +0900, Tejun Heo wrote: Hello, James. James Bottomley wrote: On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: -* Insert this command at the head of the queue for it's device. -* It will go before all other commands that are

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-20 Thread Tejun Heo
Hello, James. This is the modified patch with the comment (slightly modified). With this patch, the next patch in this patchset complains about line offset but it's okay. Thanks. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Index: scsi-reqfn-export/drivers/scsi/scsi_lib.c

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-19 Thread Tejun Heo
03_scsi_REQ_SPECIAL_semantic_scsi_queue_insert.patch scsi_queue_insert() used to use blk_insert_request() for requeueing requests. This depends on the unobvious behavior of blk_insert_request() setting REQ_SPECIAL and REQ_SOFTBARRIER when requeueing. This patch

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-19 Thread Tejun Heo
03_scsi_REQ_SPECIAL_semantic_scsi_queue_insert.patch scsi_queue_insert() used to use blk_insert_request() for requeueing requests. This depends on the unobvious behavior of blk_insert_request() setting REQ_SPECIAL and REQ_SOFTBARRIER when requeueing. This patch