On Tue, 2005-04-05 at 15:19 +0900, Tejun Heo wrote:
> No problem. Do you want me to do that now? Or is it okay to do the
> next take after you review the request_fn rewrite patch?
Just on resubmit ... I think you're currently reworking the request_fn
patch based on Christoph's comments, so
Hello, James.
James Bottomley wrote:
On Fri, 2005-04-01 at 14:25 +0900, Tejun Heo wrote:
Ah.. with later requeue path consolidation patches, all requests get
their sense buffer cleared during requeueing, which, IMHO, is more
logical. Moving scsi_init_cmd_errh() should come after the patch.
Hello, James.
James Bottomley wrote:
On Fri, 2005-04-01 at 14:25 +0900, Tejun Heo wrote:
Ah.. with later requeue path consolidation patches, all requests get
their sense buffer cleared during requeueing, which, IMHO, is more
logical. Moving scsi_init_cmd_errh() should come after the patch.
On Tue, 2005-04-05 at 15:19 +0900, Tejun Heo wrote:
No problem. Do you want me to do that now? Or is it okay to do the
next take after you review the request_fn rewrite patch?
Just on resubmit ... I think you're currently reworking the request_fn
patch based on Christoph's comments, so
On Fri, 2005-04-01 at 14:25 +0900, Tejun Heo wrote:
> Ah.. with later requeue path consolidation patches, all requests get
> their sense buffer cleared during requeueing, which, IMHO, is more
> logical. Moving scsi_init_cmd_errh() should come after the patch.
> Sorry. :-)
>
> I'll make another
On Fri, 2005-04-01 at 14:25 +0900, Tejun Heo wrote:
Ah.. with later requeue path consolidation patches, all requests get
their sense buffer cleared during requeueing, which, IMHO, is more
logical. Moving scsi_init_cmd_errh() should come after the patch.
Sorry. :-)
I'll make another take
Hello, Christoph.
On Thu, Mar 31, 2005 at 11:20:40AM +0100, Christoph Hellwig wrote:
> > +/*
> > + * Macro to determine the size of SCSI command. This macro takes vendor
> > + * unique commands into account. SCSI commands in groups 6 and 7 are
> > + * vendor unique and we will depend upon the
Hello, James.
On Thu, Mar 31, 2005 at 12:07:44PM -0600, James Bottomley wrote:
> On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote:
> > Move request preparations scattered in scsi_request_fn() and
> > scsi_dispatch_cmd() into scsi_prep_fn().
> >
> > * CDB_SIZE check in
On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote:
> Move request preparations scattered in scsi_request_fn() and
> scsi_dispatch_cmd() into scsi_prep_fn().
>
> * CDB_SIZE check in scsi_dispatch_cmd()
> * SCSI-2 LUN preparation in scsi_dispatch_cmd()
> *
> +/*
> + * Macro to determine the size of SCSI command. This macro takes vendor
> + * unique commands into account. SCSI commands in groups 6 and 7 are
> + * vendor unique and we will depend upon the command length being
> + * supplied correctly in cmd_len.
> + */
> +#define CDB_SIZE(cmd)
08_scsi_move_preps_to_prep_fn.patch
Move request preparations scattered in scsi_request_fn() and
scsi_dispatch_cmd() into scsi_prep_fn().
* CDB_SIZE check in scsi_dispatch_cmd()
* SCSI-2 LUN preparation in scsi_dispatch_cmd()
* scsi_init_cmd_errh() in
08_scsi_move_preps_to_prep_fn.patch
Move request preparations scattered in scsi_request_fn() and
scsi_dispatch_cmd() into scsi_prep_fn().
* CDB_SIZE check in scsi_dispatch_cmd()
* SCSI-2 LUN preparation in scsi_dispatch_cmd()
* scsi_init_cmd_errh() in
+/*
+ * Macro to determine the size of SCSI command. This macro takes vendor
+ * unique commands into account. SCSI commands in groups 6 and 7 are
+ * vendor unique and we will depend upon the command length being
+ * supplied correctly in cmd_len.
+ */
+#define CDB_SIZE(cmd)
On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote:
Move request preparations scattered in scsi_request_fn() and
scsi_dispatch_cmd() into scsi_prep_fn().
* CDB_SIZE check in scsi_dispatch_cmd()
* SCSI-2 LUN preparation in scsi_dispatch_cmd()
*
Hello, Christoph.
On Thu, Mar 31, 2005 at 11:20:40AM +0100, Christoph Hellwig wrote:
+/*
+ * Macro to determine the size of SCSI command. This macro takes vendor
+ * unique commands into account. SCSI commands in groups 6 and 7 are
+ * vendor unique and we will depend upon the command
Hello, James.
On Thu, Mar 31, 2005 at 12:07:44PM -0600, James Bottomley wrote:
On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote:
Move request preparations scattered in scsi_request_fn() and
scsi_dispatch_cmd() into scsi_prep_fn().
* CDB_SIZE check in scsi_dispatch_cmd()
16 matches
Mail list logo
