Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-29 Thread Chen Gang
On 09/30/2013 04:23 AM, Paul E. McKenney wrote: > On Sun, Sep 29, 2013 at 12:24:52PM +0800, Chen Gang wrote: >> On 09/27/2013 10:29 AM, Chen Gang wrote: >>> On 09/27/2013 02:33 AM, Paul E. McKenney wrote: On Thu, Sep 26, 2013 at 10:57:39AM +0800, Chen Gang wrote: > On 09/26/2013 04:16 AM,

Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-29 Thread Paul E. McKenney
On Sun, Sep 29, 2013 at 12:24:52PM +0800, Chen Gang wrote: > On 09/27/2013 10:29 AM, Chen Gang wrote: > > On 09/27/2013 02:33 AM, Paul E. McKenney wrote: > >> On Thu, Sep 26, 2013 at 10:57:39AM +0800, Chen Gang wrote: > >>> On 09/26/2013 04:16 AM, Paul E. McKenney wrote: > On Wed, Sep 25, 2013

Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-28 Thread Chen Gang
On 09/27/2013 10:29 AM, Chen Gang wrote: > On 09/27/2013 02:33 AM, Paul E. McKenney wrote: >> On Thu, Sep 26, 2013 at 10:57:39AM +0800, Chen Gang wrote: >>> On 09/26/2013 04:16 AM, Paul E. McKenney wrote: On Wed, Sep 25, 2013 at 10:55:30AM +0800, Chen Gang wrote: > > Thank you for your

Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-26 Thread Chen Gang
On 09/27/2013 02:33 AM, Paul E. McKenney wrote: > On Thu, Sep 26, 2013 at 10:57:39AM +0800, Chen Gang wrote: >> On 09/26/2013 04:16 AM, Paul E. McKenney wrote: >>> On Wed, Sep 25, 2013 at 10:55:30AM +0800, Chen Gang wrote: Thank you for your whole work, firstly :-). And your su

Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-26 Thread Paul E. McKenney
On Thu, Sep 26, 2013 at 10:57:39AM +0800, Chen Gang wrote: > On 09/26/2013 04:16 AM, Paul E. McKenney wrote: > > On Wed, Sep 25, 2013 at 10:55:30AM +0800, Chen Gang wrote: > >> > >> Thank you for your whole work, firstly :-). > >> > >> And your suggestion about testing (in our discussion) is also

Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-25 Thread Chen Gang
On 09/26/2013 04:16 AM, Paul E. McKenney wrote: > On Wed, Sep 25, 2013 at 10:55:30AM +0800, Chen Gang wrote: >> >> Thank you for your whole work, firstly :-). >> >> And your suggestion about testing (in our discussion) is also valuable >> to me. >> >> I need start LTP in q4. After referenced your

Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-25 Thread Paul E. McKenney
On Wed, Sep 25, 2013 at 10:55:30AM +0800, Chen Gang wrote: > > Thank you for your whole work, firstly :-). > > And your suggestion about testing (in our discussion) is also valuable > to me. > > I need start LTP in q4. After referenced your suggestion, my first step > for using/learning LTP is

Re: [PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-24 Thread Chen Gang
Thank you for your whole work, firstly :-). And your suggestion about testing (in our discussion) is also valuable to me. I need start LTP in q4. After referenced your suggestion, my first step for using/learning LTP is not mainly for finding kernel issues, but for testing kernel (to improve m

[PATCH tip/core/rcu 08/11] rcu: Micro-optimize rcu_cpu_has_callbacks()

2013-09-24 Thread Paul E. McKenney
From: "Paul E. McKenney" The for_each_rcu_flavor() loop unconditionally scans all flavors, even when the first flavor might have some non-lazy callbacks. Once the loop has seen a non-lazy callback, further passes through the loop cannot change the state. This is not a huge problem, given that t