Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style'

2013-09-03 Thread Chen Gang
On 09/03/2013 05:27 PM, Jiri Kosina wrote: > On Tue, 3 Sep 2013, Chen Gang wrote: > >> Do you mean "coding style", not "colding style"? (or it is my >> misunderstanding?). >> >> >>> You're not going to run checkpatch.pl on the whole kernel tree and fix >>> all the complaints, are you? >>> >> >> I

Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style'

2013-09-03 Thread Chen Gang
It seems necessary to explain my goal (why I intended to send this patch). 1. support the 'work' of Joe and triv...@kernel.org. in my opinion, 'trivial' means none-urgent, but it also means important. (if both none-urgent and none-important, why need it?) so I intend to send 1 or 2

Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style'

2013-09-03 Thread Jiri Kosina
On Tue, 3 Sep 2013, Chen Gang wrote: > Do you mean "coding style", not "colding style"? (or it is my > misunderstanding?). > > > > You're not going to run checkpatch.pl on the whole kernel tree and fix > > all the complaints, are you? > > > > I am not going to, it seems that may be the 'job' o

Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style'

2013-09-03 Thread Chen Gang
On 09/03/2013 04:55 PM, Li Zefan wrote: > Please don't. Pure colding style cleanup is discouraged. > Pardon? Do you mean "coding style", not "colding style"? (or it is my misunderstanding?). > You're not going to run checkpatch.pl on the whole kernel tree and fix > all the complaints, are you?

Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style'

2013-09-03 Thread Li Zefan
Please don't. Pure colding style cleanup is discouraged. You're not going to run checkpatch.pl on the whole kernel tree and fix all the complaints, are you? On 2013/9/3 16:29, Chen Gang wrote: > For 'switch case', remove redundancy '\t' (also can let related lines > within 80 columns) and remove

[PATCH trivial] block/ioctl.c: let code match 'kernel code style'

2013-09-03 Thread Chen Gang
For 'switch case', remove redundancy '\t' (also can let related lines within 80 columns) and remove redundancy empty lines, just like other 'switch case' which match 'kernel code style' within the file. Let blkpg_ioctl() within 80 columns. Let 2nd line of blkdev_ioctl() and __blkdev_driver_ioctl()