Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 16:01, Bryan Wu wrote: > drivers/net/e100.c: ns->tx_window_errors += > le32_to_cpu(s->tx_late_collisions); > drivers/net/e100.c: ns->tx_carrier_errors += > le32_to_cpu(s->tx_lost_crs); > drivers/net/e100.c: ns->tx_fifo_errors += >

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Robert Hancock
Bryan Wu wrote: On Sun, 2007-07-15 at 14:17 +0200, Michael Buesch wrote: On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: @@ -483,9 +487,12 @@ void setup_mac_addr(u8 * mac_addr) { + u32 addr_low = le32_to_cpu(*(u32 *) & mac_addr[0]); + u16 addr_hi = le16_to_cpu(*(u16 *) &

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 14:17 +0200, Michael Buesch wrote: > On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: > > @@ -483,9 +487,12 @@ > > > > void setup_mac_addr(u8 * mac_addr) > > { > > + u32 addr_low = le32_to_cpu(*(u32 *) & mac_addr[0]); > > + u16 addr_hi = le16_to_cpu(*(u16 *) &

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: > @@ -483,9 +487,12 @@ > > void setup_mac_addr(u8 * mac_addr) > { > + u32 addr_low = le32_to_cpu(*(u32 *) & mac_addr[0]); > + u16 addr_hi = le16_to_cpu(*(u16 *) & mac_addr[4]); > + > /* this depends on a little-endian machine */ > -

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 11:53 +0100, Christoph Hellwig wrote: > On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: > > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) >

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 12:36 +0200, Michael Buesch wrote: > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > >

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Christoph Hellwig
On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > > +# define bfin_mac_free(dma_handle, ptr)

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > +#if defined(CONFIG_BFIN_MAC_USE_L1) > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > +#else > +# define bfin_mac_alloc(dma_handle, size) \ > +

[PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. - add timeout control - kill dma_config_reg bitfields - some trivial cleanup Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Cc: Michael Buesch <[EMAIL PROTECTED]> Cc: Mike

[PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. - add timeout control - kill dma_config_reg bitfields - some trivial cleanup Signed-off-by: Bryan Wu [EMAIL PROTECTED] Cc: Michael Buesch [EMAIL PROTECTED] Cc: Mike

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: +#if defined(CONFIG_BFIN_MAC_USE_L1) +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) +#else +# define bfin_mac_alloc(dma_handle, size) \ +

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Christoph Hellwig
On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: +#if defined(CONFIG_BFIN_MAC_USE_L1) +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr)

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 12:36 +0200, Michael Buesch wrote: On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: +#if defined(CONFIG_BFIN_MAC_USE_L1) +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) +#else

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 11:53 +0100, Christoph Hellwig wrote: On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: +#if defined(CONFIG_BFIN_MAC_USE_L1) +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) +#

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: @@ -483,9 +487,12 @@ void setup_mac_addr(u8 * mac_addr) { + u32 addr_low = le32_to_cpu(*(u32 *) mac_addr[0]); + u16 addr_hi = le16_to_cpu(*(u16 *) mac_addr[4]); + /* this depends on a little-endian machine */ -

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 14:17 +0200, Michael Buesch wrote: On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: @@ -483,9 +487,12 @@ void setup_mac_addr(u8 * mac_addr) { + u32 addr_low = le32_to_cpu(*(u32 *) mac_addr[0]); + u16 addr_hi = le16_to_cpu(*(u16 *) mac_addr[4]); +

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Robert Hancock
Bryan Wu wrote: On Sun, 2007-07-15 at 14:17 +0200, Michael Buesch wrote: On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: @@ -483,9 +487,12 @@ void setup_mac_addr(u8 * mac_addr) { + u32 addr_low = le32_to_cpu(*(u32 *) mac_addr[0]); + u16 addr_hi = le16_to_cpu(*(u16 *)

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 16:01, Bryan Wu wrote: drivers/net/e100.c: ns-tx_window_errors += le32_to_cpu(s-tx_late_collisions); drivers/net/e100.c: ns-tx_carrier_errors += le32_to_cpu(s-tx_lost_crs); drivers/net/e100.c: ns-tx_fifo_errors +=