Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params

2020-12-02 Thread Mikhail Durnev
On 03.12.2020 08:57, Kuninori Morimoto wrote: I think you want to add "fallthrough" between case 1/3/4 and case 0 ? Hi Morimoto-san, Yes, I will add it in the updated version of the patch. Thanks. The checkpatch script did not tell me about that. Best regards, Misha

Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params

2020-12-02 Thread Kuninori Morimoto
Hi Mikhail Thank you for your patch > + switch (rsnd_mod_id(src_mod)) { > + /* > + * SRC0 can downsample 4, 6 and 8 channel audio up to 4 > times. > + * SRC1, SRC3 and SRC4 can downsample 4 channel audio > +

Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params

2020-12-02 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on asoc/for-next] [also build test ERROR on v5.10-rc6 next-20201201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https:/

Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params

2020-12-02 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v5.10-rc6 next-20201201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

[PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params

2020-12-02 Thread mdurnev
From: Mikhail Durnev snd_pcm_hw_params_set_rate_near can return incorrect sample rate in some cases, e.g. when the backend output rate is set to some value higher than 48000 Hz and the input rate is 8000 Hz. So passing the value returned by snd_pcm_hw_params_set_rate_near to snd_pcm_hw_params wil