Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-10 Thread Jason Gunthorpe
On Thu, Aug 10, 2017 at 05:47:48AM +0300, Dmitry V. Levin wrote: > On Wed, Aug 09, 2017 at 09:52:41AM -0600, Jason Gunthorpe wrote: > > On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > > >

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-10 Thread Jason Gunthorpe
On Thu, Aug 10, 2017 at 05:47:48AM +0300, Dmitry V. Levin wrote: > On Wed, Aug 09, 2017 at 09:52:41AM -0600, Jason Gunthorpe wrote: > > On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > > >

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-09 Thread Dmitry V. Levin
On Wed, Aug 09, 2017 at 09:52:41AM -0600, Jason Gunthorpe wrote: > On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > > userspace users of this file, 'sockaddr_in' needs to come from glibc's > > >

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-09 Thread Dmitry V. Levin
On Wed, Aug 09, 2017 at 09:52:41AM -0600, Jason Gunthorpe wrote: > On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > > userspace users of this file, 'sockaddr_in' needs to come from glibc's > > >

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-09 Thread Jason Gunthorpe
On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > userspace users of this file, 'sockaddr_in' needs to come from glibc's > > 'netinet/in.h' instead.. > Is it wrong to include include/uapi/linux/in.h from

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-09 Thread Jason Gunthorpe
On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > userspace users of this file, 'sockaddr_in' needs to come from glibc's > > 'netinet/in.h' instead.. > Is it wrong to include include/uapi/linux/in.h from

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-09 Thread Moni Shoua
> > I'm not sure this is a good idea, linux/in.h should not be included in > userspace users of this file, 'sockaddr_in' needs to come from glibc's > 'netinet/in.h' instead.. > > Jason Is it wrong to include include/uapi/linux/in.h from userspace?

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-09 Thread Moni Shoua
> > I'm not sure this is a good idea, linux/in.h should not be included in > userspace users of this file, 'sockaddr_in' needs to come from glibc's > 'netinet/in.h' instead.. > > Jason Is it wrong to include include/uapi/linux/in.h from userspace?

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-08 Thread Jason Gunthorpe
On Sun, Aug 06, 2017 at 06:44:21PM +0200, Mikko Rapeli wrote: > Fixes these userspace compilation errors when rdma_user_rxe.h is compiled > alone: > > rdma/rdma_user_rxe.h:59:20: error: field ???_sockaddr??? has incomplete type >struct sockaddr _sockaddr; > ^ >

Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-08 Thread Jason Gunthorpe
On Sun, Aug 06, 2017 at 06:44:21PM +0200, Mikko Rapeli wrote: > Fixes these userspace compilation errors when rdma_user_rxe.h is compiled > alone: > > rdma/rdma_user_rxe.h:59:20: error: field ???_sockaddr??? has incomplete type >struct sockaddr _sockaddr; > ^ >

[PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-06 Thread Mikko Rapeli
Fixes these userspace compilation errors when rdma_user_rxe.h is compiled alone: rdma/rdma_user_rxe.h:59:20: error: field ‘_sockaddr’ has incomplete type struct sockaddr _sockaddr; ^ rdma/rdma_user_rxe.h:60:22: error: field ‘_sockaddr_in’ has incomplete type

[PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-06 Thread Mikko Rapeli
Fixes these userspace compilation errors when rdma_user_rxe.h is compiled alone: rdma/rdma_user_rxe.h:59:20: error: field ‘_sockaddr’ has incomplete type struct sockaddr _sockaddr; ^ rdma/rdma_user_rxe.h:60:22: error: field ‘_sockaddr_in’ has incomplete type